Query string in request exception about phroute HOT 15 CLOSED

Adding the {foo}? in the tail of route declaration make the request (see above) working perfectly,
BUT broke following request: /api/account/285/token/ :-(

from phroute.

May be make route string insensitive for query string (?...)?

from phroute.

Adding get /api/account/{user_id:i}/token/
and get /api/account/{user_id:i}/token/{q}?

is only way for me now... And it seems as big workaround...

from phroute.

How are you dispatching the route?

There is no need to pass the query string into the route dispatcher.

Could you post your dispatch code?

Cheers
Joe Green

On 25 Sep 2014, at 18:39, Александр [email protected] wrote:

Adding get /api/account/{user_id:i}/token/
and get /api/account/{user_id:i}/token/{q}?

is only way for me now...

—
Reply to this email directly or view it on GitHub.

from phroute.

I do it now:

    $router->get('/api/account/{user_id:i}/token/', $get_tokens); // not working for /api/account/285/token/?name=info-product
    $router->get('/api/account/{user_id:i}/token/{q}?', $get_tokens);

from phroute.

$get_tokens is a lambda:

    $get_tokens = function ($user_id) {
        $token_name = !empty($_GET['name']) ? $_GET['name'] : '';
        return \User\Token\get($user_id, $token_name);
    };

from phroute.

No not the route collection. I need the dispatch code - something like this:

$dispatcher = new Phroute\Dispatcher($router);

$response = $dispatcher->dispatch($_SERVER['REQUEST_METHOD'], $_SERVER['REQUEST_URI']);

from phroute.

Basically you are dispatching this:

$dispatcher->dispatch('GET', '/api/account/285/token/?name=info-product');

when you should be dispatching this:

$dispatcher->dispatch('GET', '/api/account/285/token/');

The router is not concerned with the query string. Hope that helps a little, but if you can post your dispatch code I'll take a look and see if I can help further.

from phroute.

$router->get('/api/account/{user_id:i}/token', $get_tokens); is the correct set up for the route /api/account/285/token

from phroute.

My dispatcher is exactly same.

And i understood, what the root of this trouble now :-)

I must use following expression

parse_url($_SERVER["REQUEST_URI"])['path']

instead of simple $_SERVER["REQUEST_URI"] in the dispatcher.

Thank you for right idea!
And thank you for grateful library!

from phroute.

Yeah! It working now.

    $response = $dispatcher->dispatch($_SERVER['REQUEST_METHOD'], parse_url($_SERVER["REQUEST_URI"])['path']);

What about updating example (in readme.md) with above fix?

from phroute.

I see :) I will indeed update the readme. Thank you!

I rarely use the superglobals directly, and I had forgotten that the REQUEST_URI global contains the query string too. This should have occurred to me as soon as you posted this. My apologies.

I usually use something like this as a starting point for my web applications. Its not a framework, just a basic entry point for a web app, which in this case uses the symfony foundation request library to access the request information.
https://github.com/joegreen0991/framework/blob/master/app/app.php#L31

from phroute.

Done! Thanks for the feedback :)

from phroute.

I'm glade!

from phroute.

Please add this line to README, it's very helpful one :)

$response = $dispatcher->dispatch($_SERVER['REQUEST_METHOD'],   parse_url($_SERVER["REQUEST_URI"])['path']);

from phroute.