Disable log on autocomplete/eager-eval about echo HOT 7 OPEN

There's an ownKeys handler: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Proxy/handler/ownKeys

Might be able to find a solution to #14 that complements this one

from echo.

What if simply getting global.Echo didn't trigger an autolog, but instead it waited until the first call/construct/get? Could just change the condition from maxTokensLength > 0 to 1.

Only makes sense if we've already figured out how to disable autocomplete

Breaks most trivial usage of Echo, which could lead to confusion

from echo.

There's an ownKeys handler

DevTools doesn't use the ownKeys handler, it hooks into v8 to inspect the object directly :/

• at runtimeAgent.invoke_getProperties (as in, hook into v8 stuff)
• at RemoteObjectImpl#getOwnProperties()
• at JavaScriptAutoComplete#completionsOnGlobal
• at JavaScriptAutoComplete#_completionsForExpression

from echo.

Does Chrome even still eager-eval Echo?

It does not, and afaict adding side-effects to the internal Echo function causes no change in functionality

from echo.

Autocomplete seems to stop after a construct (potentially also a call) -- or does it? Maybe there's a way to take advantage of that?

It looks like autocomplete decides whether something has side effects based solely on the token types: https://github.com/ChromeDevTools/devtools-frontend/blob/e43879a5a25ec7bfaaedeb1e4d860181db696d09/front_end/formatter_worker/FormatterWorker.js#L463 Autocomplete is aborted if the expression contains anything that is not one of the "safe" types 'MemberExpression', 'Identifier', 'BinaryExpression', 'Literal', 'TemplateLiteral', 'TemplateElement', 'ObjectExpression', 'ArrayExpression', 'Property', 'ThisExpression'

from echo.

It looks like throwing an error could abort autocomplete -- is there a way to throw an error during the get handler without disrupting functionality?

from echo.

Oh god now new versions of Node (I'm playing with 14.15) do autocomplete too and it's so much worse in a CLI

from echo.