Giter Club home page Giter Club logo

Comments (4)

mrin9 avatar mrin9 commented on July 19, 2024

can you provide an open-api spec, where you see this issue

from rapipdf.

robbito avatar robbito commented on July 19, 2024

Here is a minimal api spec:

openapi.zip

I guess the problem is, that schemaToPdf does not use getTypeInfo(). Maybe this could be added with an option

BTW: I think the code needs a general refactoring. Works in general, good job, but structure, naming, etc. needs to be improved (no offense intended :-))

from rapipdf.

mrin9 avatar mrin9 commented on July 19, 2024

Currently we show type, format, patterns and constrain info for query, form, path and header params.
For request-body which generally is an object we are having some internal discussion on how best we can put this info in a printable manner without skewing the objects indentation structure. We have some designs that we are running through our test cases and collecting feedbacks from some of our clients.

we do have a plan to show this info and as you correctly mentioned we already have done some ground work for it getTypeInfo().

Regarding the code, one of our top priority is apply a JS style linter . If you are willing, I am happy to take a PR on this. the first step would be to just lint it without changing any names, thereafter we visit the rest

from rapipdf.

mrin9 avatar mrin9 commented on July 19, 2024

in release 2.0.0 code has been refactored and JS linter is applied. Type info about field types are now printed in the object model.

from rapipdf.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.