Switch syntax highlighting to Rouge about infoq-mini-book HOT 14 CLOSED

This will require switching to AsciidoctorJ 2, since that's what provides Rouge for the HTML conversion. But we could start by switching the PDF build.

from infoq-mini-book.

@mojavelinux I have this HTML block that renders funny after the change.

[source,html]
.src/app/search/search.component.html
----
<form>
  <input type="search" name="query" [(ngModel)]="query" (keyup.enter)="search()">
  <button type="button" (click)="search()">Search</button>
</form>
----

It's Angular HTML, but the highlights are off.

Here's what it looks like before switching.

from infoq-mini-book.

That's an indication the rouge gem is out of date. Support for Angular was fixed in a recent version (specifically 3.7.0). AsciidoctorJ PDF needs to upgrade in the next release (which is due out soon). See https://github.com/asciidoctor/asciidoctorj-pdf/blob/master/build.gradle#L51

from infoq-mini-book.

@mojavelinux I created a PR to upgrade the gem. However, I'm not sure that'll fix the problem since the example above is in the rendered HTML, not PDF.

from infoq-mini-book.

You'd need the same upgrade either way.

from infoq-mini-book.

My bad, when upgrading to new versions I only checked for upgrades in the runtime deps, not the development deps. (Not sure I fully understand what a development dependency is)

I am planning to make a release of asciidoctorj this weekend which should include rouge 3.12.0.
I’ll test how this looks like before doing that release.

from infoq-mini-book.

Not sure I fully understand what a development dependency is

A development dependency is a test suite dependency.

from infoq-mini-book.

Yes, that was what I was thinking as well.
But it’s also an optional runtime dependency, isn’t it?

Just wanted to say sorry, it’s my bad that I completely skipped the dev dependency section on rubygems.org when checking for upgrades of transitive deps.

from infoq-mini-book.

But it’s also an optional runtime dependency, isn’t it?

Yes, those that's only suggested by the docs. In other words, the integration only works if the gem is present.

from infoq-mini-book.

Where you should be looking is not on rubygems.org, but rather here: https://github.com/asciidoctor/asciidoctor-pdf/blob/master/Gemfile

from infoq-mini-book.

I'll make a release of asciidoctorj-pdf 1.5.0-beta.7.1 that contains an updated version of rouge.
Relying on the current version in asciidoctorj will not be enough since users of asciidoctorj-pdf might still work with asciidoctorj 1.5.x or 1.6.x.

from infoq-mini-book.

I would recommend waiting for 1.5.0.rc.1 (or, if things go sideways, beta.8), which should be out later this week.

from infoq-mini-book.

OK, then I'll wait. I'll create a PR though to update rouge to the latest 3.12.0 also in asciidoctor-pdf and to add chunky_png, which I was also missing as I have just seen.

The pdf output of of the angular snippet will look like this with 3.12.0, I guess this is ok:

from infoq-mini-book.

add chunky_png, which I was also missing as I have just seen

If I look at the Gemfile it's not there, so I am not going to add it.

from infoq-mini-book.