Comments (3)
It used to, and in my opinion it was terrible.
Also, most complexity actually comes from automatically matching the latest release tags, which git submodules can't do at all.
from mpv-build.
Okay, thanks.
I don't actually know anything about git submodules, but I had seen it in some repositories. It'd be interesting to hear your specific problems with it, or maybe you could point me to where it was previously discussed, but in any case, I think this issue can be closed.
from mpv-build.
It'd be interesting to hear your specific problems with it,
First of all, git submodules can point only to a specific fixed commit. You can't point them to a branch of a tag, and you can't do anything fancy like "picking the tag with the latest version" either. Second, it's actually very trivial to checkout or update a bunch of git checkouts with a script, and git submodules don't really add much convenience. Third, git submodules are strange. E.g. if you change a submodule repo, the parent repo will list the submodule as changed. There are other such weird interactions, which just get in the way. In summary, at least for out use case git submodules suck a lot.
The discussion happened mostly on IRC.
Closing.
from mpv-build.
Related Issues (20)
- Can't build with meson HOT 21
- libmpv fails linking with meson HOT 7
- git master build with meson fails HOT 6
- Confused about dependencies in build instructions. HOT 4
- Can't link libmpv (deb package) on Debian 11 HOT 3
- Can't build libmpv with '-Wl,-Bsymbolic' option on Mac HOT 2
- compiled libmpv.2.dylib can't use HOT 1
- No binary after successful(?) rebuild on Fedora HOT 6
- (Ubuntu) meson: error: unrecognized arguments: --enable-vapoursynth --enable-libmpv-shared HOT 5
- Can't build on Ubuntu 20.04 with latest libplacebo HOT 1
- Feature request: Gracefully handle uncommited changes when updating
- Why Debian packaging scripts do not currently support libmpv ? CentOS Is it feasible?
- mpv-build: autoreconf: error: aclocal failed with exit status: 1 HOT 1
- error: implicit declaration of function 'mp_csp_to_avcol_spc' HOT 5
- Trying to build an old fork on a new server and I'm getting "error: implicit declaration of function ‘avfilter_pad_count’" HOT 2
- Custom build can't load Lua scripts HOT 2
- mpv-build fatal error: EGL/eglplatform.h: No such file or directory
- build: freetype version 9.17.3 seems to be required for building libass while the most recent version available is 2.13.2 HOT 1
- Support js script HOT 2
- "--enable-libmp3lame" yields "libmp3lame >= 3.98.3 not found" HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from mpv-build.