Giter Club home page Giter Club logo

Comments (8)

mpobaschnig avatar mpobaschnig commented on July 27, 2024

Hey, sorry for the late response and thanks for your suggestion!

I'm not quite sure about the symmetry and distance to borders of the inner part. When looking at Password Safe icon, they use the same distance above and below. Maybe you could try the same distance as well?

Also, I think the shadow is a bit off? The shadow from the upper bars don't have the same direction as the lower ones. However, I'm not a designer, so I would welcome your opinion about this.

Could you also please attach a picture where you put your SVG into the App Icon Preview app for reference with other apps, thanks!

from vaults.

jacsonah avatar jacsonah commented on July 27, 2024

Hi, I've been drafting some other icon models.
What do you think about this?
io github mpobaschnig Vaults
image

If you prefer I can fix the first icon too.

from vaults.

mpobaschnig avatar mpobaschnig commented on July 27, 2024

This looks very good! However, the first one fits the name "Vaults" much better in my opinion, as this one goes more into the "Safe" direction. So I think improving the first icon is a better idea.

from vaults.

jacsonah avatar jacsonah commented on July 27, 2024

I centralized the inner part and removed the shadows.
I'm not a designer either, so I don't have a technical suggestion of what could be improved.
io github mpobaschnig Vaults
image

from vaults.

jacsonah avatar jacsonah commented on July 27, 2024

Here it is with another color in the inner part.

io github mpobaschnig Vaults

image

from vaults.

mpobaschnig avatar mpobaschnig commented on July 27, 2024

Looks really good now! I prefer the one with the darker inner part. Please also create the develop-version of the icon (just add this yellow/black overlay, see here).
Can you please create a merge request, replacing the .svg files (app + develop), and you can add yourself to the artists here: https://github.com/mpobaschnig/Vaults/blob/dfccf78e5cf6b66f7f25c002410764435590db00/src/application.rs#L125

from vaults.

jacsonah avatar jacsonah commented on July 27, 2024

Merge request: #19

from vaults.

mpobaschnig avatar mpobaschnig commented on July 27, 2024

Closed with commit b7d19dc

from vaults.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.