Comments (15)
Enchufa2
commented on June 8, 2024
Just wanted to note that there are more warnings from the -Wpedantic flag here. These are all pointer conversions such as
flexiblas_api_standalone.c:67:11: warning: initializing 'void *' with an expression of type 'int (*)(void)' converts between void pointer and function pointer [-Wpedantic]
void *ptr_self = &flexiblas_avail;
^ ~~~~~~~~~~~~~~~~
flexiblas_api_standalone.c:73:15: warning: assigning to 'int (*)()' from 'void *' converts between void pointer and function pointer [-Wpedantic]
fnptr = ptr_next;
^ ~~~~~~~~
from flexiblas.
grisuthedragon
commented on June 8, 2024
The strict prototypes issue is ongoing. Regarding the pendantic setting, It could be that we cannot fix it.
from flexiblas.
grisuthedragon
commented on June 8, 2024
Some update on this.... Pedantic is possible for C but not for Fortran, since there we import stuff from the reference implementation, which does not fulfill these strict requirement as well.
from flexiblas.
Enchufa2
commented on June 8, 2024
Thanks for looking into this too. In the case CRAN asks about fixing them, this is a very reasonable point for a waiver.
from flexiblas.
grisuthedragon
commented on June 8, 2024
I will take a look at the reference LAPACK sources and open an issue there. Before the pedantic problem is not fixed on their side, it is a bad idea to fix it in FlexiBLAS.
The pedantic warnings are fixed in the upcoming release with LAPACK 3.11.
from flexiblas.
Enchufa2
commented on June 8, 2024
I will take a look at the reference LAPACK sources and open an issue there.
Thanks!
Before the pedantic problem is not fixed on their side, it is a bad idea to fix it in FlexiBLAS.
Agree.
The pedantic warnings are fixed in the upcoming release with LAPACK 3.11.
Great!
from flexiblas.
Enchufa2
commented on June 8, 2024
Is v3.3.0 ready? I've seen that you pushed to GitLab.
from flexiblas.
grisuthedragon
commented on June 8, 2024
@Enchufa2 Its ready now, the sync to github failed.
from flexiblas.
Enchufa2
commented on June 8, 2024
Note that there are still some non-explicit prototypes. In particular,
flexiblas_api_standalone.c:62:20: warning: a function declaration without a prototype is deprecated in all versions of C [-Wstrict-prototypes]
flexiblas_api_standalone.c:88:31: warning: a function declaration without a prototype is deprecated in all versions of C [-Wstrict-prototypes]
flexiblas_api_standalone.c:490:30: warning: a function declaration without a prototype is deprecated in all versions of C [-Wstrict-prototypes]
flexiblas_api_standalone.c:516:45: warning: a function declaration without a prototype is deprecated in all versions of C [-Wstrict-prototypes]
flexiblas_api_standalone.c:521:29: warning: a function declaration without a prototype is deprecated in all versions of C [-Wstrict-prototypes]
flexiblas_api_standalone.c:526:44: warning: a function declaration without a prototype is deprecated in all versions of C [-Wstrict-prototypes]
flexiblas_api_standalone.c:531:24: warning: a function declaration without a prototype is deprecated in all versions of C [-Wstrict-prototypes]
flexiblas_api_standalone.c:536:39: warning: a function declaration without a prototype is deprecated in all versions of C [-Wstrict-prototypes]
flexiblas_api_standalone.c:541:25: warning: a function declaration without a prototype is deprecated in all versions of C [-Wstrict-prototypes]
flexiblas_api_standalone.c:546:40: warning: a function declaration without a prototype is deprecated in all versions of C [-Wstrict-prototypes]
flexiblas_api_standalone.c:551:22: warning: a function declaration without a prototype is deprecated in all versions of C [-Wstrict-prototypes]
flexiblas_api_standalone.c:556:37: warning: a function declaration without a prototype is deprecated in all versions of C [-Wstrict-prototypes]
flexiblas_api_standalone.c:562:45: warning: a function declaration without a prototype is deprecated in all versions of C [-Wstrict-prototypes]
from flexiblas.
grisuthedragon
commented on June 8, 2024
Can you provide the full compiler flags and the gcc version? Since I didn't them in my setup.
from flexiblas.
Enchufa2
commented on June 8, 2024
This is on CRAN. Apart from -Wstrict-prototypes, the other flags don't matter. Here's one of the offending lines:
flexiblas/src/flexiblas_api_standalone.c
Line 62 in 24f41fd
Clearly it needs a void between the parentheses. It's the same case for all the other line numbers.
from flexiblas.
grisuthedragon
commented on June 8, 2024
That's weired. The line 62 isn't a prototype. It is the implementation and therefore not required. The corresponding prototypes are in flexiblas_api.h which is generated during the cmake procedure. There, the functions are defined like:
extern int flexiblas_avail(void);
I build it on U20.04 with gcc 9.4.0 and the following commandline, and I do not get any warning:
/usr/bin/cc -DFLEXIBLAS_CBLAS -DFLEXIBLAS_LAPACK -D_FILE_OFFSET_BITS=64 -D_NONE_ \
-D_POSIX_C_SOURCE=200809L -Dflexiblas_api_EXPORTS \
-I/home/dev/work/software/flexiblas/src -I/home/dev/work/software/flexiblas/build/include \
-I/home/dev/work/software/flexiblas/include -I/home/dev/work/software/flexiblas/build \
-I/home/dev/work/software/flexiblas/libcscutils/include -I/home/dev/work/software/flexiblas/build/libcscutils/include \
-I/home/dev/work/software/flexiblas/libcscutils/src -I/home/dev/work/software/flexiblas/build/libcscutils/src \
-I/home/dev/work/software/flexiblas/build/libcscutils/include/cscutils -fPIC -std=c99 -fstack-protector-strong \
-fstack-clash-protection -D_FILE_OFFSET_BITS=64 -O3 -DNDEBUG -O3 -Wpedantic -Wstrict-prototypes \
-Wcast-qual -fPIC -Wpedantic -o CMakeFiles/flexiblas_api.dir/flexiblas_api_standalone.c.o \
-c /home/dev/work/software/flexiblas/src/flexiblas_api_standalone.c
from flexiblas.
Enchufa2
commented on June 8, 2024
The new warnings were upon submission. I found the specific command and output digging in the email (see here). I copy the output here because that file will eventually be garbage-collected:
* installing *source* package ‘flexiblas’ ...
** using staged installation
** libs
using C compiler: ‘Debian clang version 15.0.6’
clang-15 -I"/home/hornik/tmp/R-d-clang-15/include" -DNDEBUG -I/usr/local/include -DUSE_TYPE_CHECKING_STRICT -D_FORTIFY_SOURCE=2 -fpic -g -O3 -Wall -pedantic -c flexiblas_api_standalone.c -o flexiblas_api_standalone.o
flexiblas_api_standalone.c:62:20: warning: a function declaration without a prototype is deprecated in all versions of C [-Wstrict-prototypes]
int flexiblas_avail()
^
void
flexiblas_api_standalone.c:88:31: warning: a function declaration without a prototype is deprecated in all versions of C [-Wstrict-prototypes]
int flexiblas_get_color_output() {
^
void
flexiblas_api_standalone.c:490:30: warning: a function declaration without a prototype is deprecated in all versions of C [-Wstrict-prototypes]
int flexiblas_get_num_threads()
^
void
flexiblas_api_standalone.c:516:45: warning: a function declaration without a prototype is deprecated in all versions of C [-Wstrict-prototypes]
FLEXIBLAS_API_INT flexiblas_get_num_threads_()
^
void
flexiblas_api_standalone.c:521:29: warning: a function declaration without a prototype is deprecated in all versions of C [-Wstrict-prototypes]
int openblas_get_num_threads()
^
void
flexiblas_api_standalone.c:526:44: warning: a function declaration without a prototype is deprecated in all versions of C [-Wstrict-prototypes]
FLEXIBLAS_API_INT openblas_get_num_threads_()
^
void
flexiblas_api_standalone.c:531:24: warning: a function declaration without a prototype is deprecated in all versions of C [-Wstrict-prototypes]
int mkl_get_num_threads()
^
void
flexiblas_api_standalone.c:536:39: warning: a function declaration without a prototype is deprecated in all versions of C [-Wstrict-prototypes]
FLEXIBLAS_API_INT mkl_get_num_threads_()
^
void
flexiblas_api_standalone.c:541:25: warning: a function declaration without a prototype is deprecated in all versions of C [-Wstrict-prototypes]
int blas_get_num_threads()
^
void
flexiblas_api_standalone.c:546:40: warning: a function declaration without a prototype is deprecated in all versions of C [-Wstrict-prototypes]
FLEXIBLAS_API_INT blas_get_num_threads_()
^
void
flexiblas_api_standalone.c:551:22: warning: a function declaration without a prototype is deprecated in all versions of C [-Wstrict-prototypes]
int acmlgetnumthreads()
^
void
flexiblas_api_standalone.c:556:37: warning: a function declaration without a prototype is deprecated in all versions of C [-Wstrict-prototypes]
FLEXIBLAS_API_INT acmlgetnumthreads_()
^
void
flexiblas_api_standalone.c:562:45: warning: a function declaration without a prototype is deprecated in all versions of C [-Wstrict-prototypes]
FLEXIBLAS_API_INT bli_thread_get_num_threads()
^
void
13 warnings generated.
clang-15 -I"/home/hornik/tmp/R-d-clang-15/include" -DNDEBUG -I/usr/local/include -DUSE_TYPE_CHECKING_STRICT -D_FORTIFY_SOURCE=2 -fpic -g -O3 -Wall -pedantic -c init.c -o init.o
clang-15 -I"/home/hornik/tmp/R-d-clang-15/include" -DNDEBUG -I/usr/local/include -DUSE_TYPE_CHECKING_STRICT -D_FORTIFY_SOURCE=2 -fpic -g -O3 -Wall -pedantic -c wrapper.c -o wrapper.o
clang-15 -shared -L/home/hornik/tmp/R-d-clang-15/lib -Wl,-O1 -o flexiblas.so flexiblas_api_standalone.o init.o wrapper.o -L/home/hornik/tmp/R-d-clang-15/lib -lR
installing to /srv/hornik/tmp/CRAN/flexiblas.Rcheck/00LOCK-flexiblas/00new/flexiblas/libs
** R
** inst
** byte-compile and prepare package for lazy loading
** help
*** installing help indices
** building package indices
** testing if installed package can be loaded from temporary location
** checking absolute paths in shared objects and dynamic libraries
** testing if installed package can be loaded from final location
** testing if installed package keeps a record of temporary installation path
* DONE (flexiblas)
so clang 15 seems to be more strict?
from flexiblas.
grisuthedragon
commented on June 8, 2024
I did a bunch of small experiments, and it turned out that clang 15 is the first clang version which is that strict. All version < 15 are not affected by this. I will fix it, and it will be in the next release.
from flexiblas.
Enchufa2
commented on June 8, 2024
Thanks!
from flexiblas.
Related Issues (20)
- Build failure on macOS HOT 6
- Cross-compilation issues HOT 3
- Suffixed 64-bit integer symbols names HOT 17
- Compile all backends without auto-detection HOT 3
- LAPACK 3.10.0 HOT 7
- building FlexiBLAS 3.0.4 with -DMKL_CUSTOM=ON fails HOT 5
- segmentation fault with numpy on POWER9 (only) when using FlexiBLAS HOT 13
- Static build of FlexiBLAS HOT 5
- flexiblas-openblas-openmp with OMP_PROC_BIND binds the program to a single core HOT 11
- 3.1.0 build failures HOT 11
- Int instead of int in standalone API HOT 3
- Wrong -verbose flag in CXXFLAGS HOT 2
- Documentation on switching backends HOT 8
- No LAPACK API version specified HOT 7
- Improving backend auto detection HOT 5
- Missing flexiblas-octave tar in release v3.2.0 HOT 2
- macOS support HOT 4
- Strange annocheck reports HOT 2
- macOS vecLib Accelerate Framework thread setting HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from flexiblas.