Giter Club home page Giter Club logo

Comments (4)

mpaland avatar mpaland commented on May 24, 2024

Hello @acesme ,
thank you for your comment!
As a matter of fact, it's a really good question. I would say (or suggest) it shouldn't.
In the moment, the low level _putchar() function is responsible for the printf() output, so any \0 could be filtered out easily.
Normally the plain native printf()is used to output strings to the screen or a terminal and a terminator isn't needed or even unwanted.
Have to check it... Any other opinions/suggestions here?

from printf.

acesme avatar acesme commented on May 24, 2024

Yes, it is simple to filter out the final '\0' in the _putchar() implementation.
It is also possible (albeit a little hacky) to fix this on 653rd row of printf.c by checking if out == _out_char and opting to not append the '\0' (or something like that).
I have no other suggestions that I can think of for now.

from printf.

mpaland avatar mpaland commented on May 24, 2024

I think, it's better to "fix" this in _out_char() itself, so other output functions won't get any penalty, something like

static inline void _out_char(char character, char* buffer, size_t idx, size_t maxlen)
{
  (void)buffer; (void)idx; (void)maxlen;
  if (character) {
    _putchar(character);
  }
}

from printf.

mpaland avatar mpaland commented on May 24, 2024

I think, suppressing the terminating \0 is conform to the standard.
@acesme, thanx for bringing this to attention. Fixed.

from printf.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.