building from source broken about zilla-slab HOT 6 CLOSED

Done, thanks @shinenelson

from zilla-slab.

I hit this when installing on OSX too in #5 (comment)

The simplest fix was to run brew install ttfautohint. We should probably add this to the docs. As for building without autohint, I'm not sure if this is something we'd want to do. Any thoughts @m4rc1e?

Also, I don't think I would expect most users to want to build the fonts from source. Most will simply download the compiled zip.

from zilla-slab.

I also see you opened #22 to update the readme, but accepting that change seems dependent on the answer to the comment above.

from zilla-slab.

We should probably add this to the docs.

Agreed. Should I add another line mentioning this dependency on the README.md in pull #22 ?

As for building without autohint, I'm not sure if this is something we'd want to do.

I'm not in favor of that either. I was just indicating a temporary workaround until fontmake could put in a proper fix or a proper exception rather than like a fatal, un-handled exception stack-trace; like @m4rc1e mentioned in #5 (comment).

Also, I don't think I would expect most users to want to build the fonts from source. Most will simply download the compiled zip.

There are a few developers / enthusiasts (like me) who love building / compiling everything from source. I speak for their sake. Also, the instructions are for building from source right? The download instructions are provided in the Download section in the beginning of the README.md file right?

I also see you opened #22 to update the readme, but accepting that change seems dependent on the answer to the comment above.

I think both #21 and #22 are independent of the autohint issue. I deliberately did not include them since I wanted to put that up for discussion before making any changes. I think both of them can be merged even if we don't come to a consensus / decision about what to do about autohint.

from zilla-slab.

Ok - things I think we can do to close this issue:

1. Yes please, add brew install ttautohint to the install instructions. This should fix the primary issue reported here.
2. Yes I think we can merge #22 to cover Linux once it’s reviewed (many thanks there).
3. The readme does already mention both sfnt2woff and woff2 as dependencies, despite you saying they are not mentioned. Perhaps this is not clear enough, in which case we can try and explain things better. We can look at this in your PR.

from zilla-slab.

Done. Can you take a look at #22 now @alexgibson?

from zilla-slab.