Comments (2)
Perhaps we just need to check nsDocShell::GetIsMozBrowserOrApp before deciding whether or not to enforce the frame-ancestor policy, although it returns false in this case, as mFrameType is FRAME_TYPE_REGULAR for the docshell, which seems wrong. So perhaps it's being set incorrectly somewhere.
See my comment, seems like a more general problem than just CSP.
It could also be an issue that nsCSPContext::PermitsAncestry generates ancestorsArray by walking the docshell tree until it reaches a docshell whose document URI scheme is chrome, which won't be the case here, as the URL of the document that contains the mozbrowser will be a file: URL like file:///path/to/positron/test/hello-world/index.html.
I agree checking for the chrome
scheme seems suspicious. I would think this code actually wants to check for typeChrome
on the parent tree item instead. That's how most code paths seem to find the the top of the content tree.
from positron.
Upstream bug with fix using @jryans suggestions of checking ItemType https://bugzilla.mozilla.org/show_bug.cgi?id=1277102
from positron.
Related Issues (20)
- Git complains about user's identity in task run
- console.log logs to terminal but not console window HOT 5
- Resources for beginners? (very interested) HOT 10
- determine correct way to express SpiderNode dependency on static:js
- determine correct way to express libxul dependency on SpiderNode on Linux
- determine correct way to specify positron/app/spidernode subconfigure dir
- node-integration builds busted on Linux because static lib locations differ
- Fix shutdown memory leak
- Add lock for isolate in NodeBindings
- Emit loaded event from node bindings
- Move node bindings and node loader out of webidl folder HOT 5
- MOZ_CRASH(Accessing the Subject Principal without an AutoJSAPI on the stack is forbidden) at /Users/myk/Projects/positron/dom/base/nsContentUtils.cpp:2760 HOT 3
- cp: cannot create regular file '…libzlib.a': File exists
- Call add-on sdk functionality from Positron HOT 12
- synchronously retrieve back/forward status of mozbrowser HOT 3
- figure out if/when to set WebViewImpl.attached/elementAttached
- benchmark Positron perf and compare it to Electron HOT 1
- GuestWebContentsPrototype.getURL fails because contentDocument is null
- loading renderer modules in single sandbox throws "TypeError: 'get location' called on an object that does not implement interface Window."
- Find or implement an event similar to blink's NavigationEntryCommitted
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from positron.