"hello world" app doesn't quit when I close its window about positron HOT 8 CLOSED

Happens on Windows too, BTW.

from positron.

@jryans I think this is a regression from integrating DevTools.

from positron.

Hmm, what about the call to Services.startup.enterLastWindowClosingSurvivalArea();? Wouldn't that trigger this behavior on all OSes @mykmelez?

from positron.

Hmm, what about the call to Services.startup.enterLastWindowClosingSurvivalArea();? Wouldn't that trigger this behavior on all OSes @mykmelez?

That prevents Gecko from quitting the app, but the app itself should still do it on window-all-closed:

https://github.com/mozilla/positron/blob/master/positron/test/hello-world/main.js#L11-L18

from positron.

This comment could be relevant:

from positron.

I'll take a look at this.

from positron.

Hmm, I commented out the OS check in main.js to try on OS X. In that case, the app does quit after closing the app window.

I'll try setting up my VM for builds on other OSes.

from positron.

Hmm, looking at the timing of events, on Mac we get domwindowclosed for DevTools first, then the app window. On Linux, the app window event comes first, quit is called, then DevTools window closes after. So, it seems the quit call is getting aborted somehow. I'll look more tomorrow.

from positron.