Comments (7)
I see, a call to /v1/profile
on the profile server calls /v1/avatar
. The initial avatar load takes 5+ seconds, then a second fetch occurs for just the avatar data, adding 5 more seconds.
This is sub-optimal. The profile data fetch done in settings.js->beforeRender already returns the avatar data, the call to /v1/avatar from account.fetchCurrentProfileImage in settings.js->afterVisible fetches no new information and only is only used to fetch the avatar id and slows down the perceived load time.
I wonder if we can speed this up using two approaches:
- Ditch the redundant call to
/v1/avatar
- Call
account.fetchProfile()
inafterVisible
The first seems relatively safe, the second I'm unsure of the repercussions.
from fxa.
Ref #2980
from fxa.
This is a partial dup of #2980.
from fxa.
More info - the call to /v1/avatar
may be done because /v1/profile
only returns the avatar URL and not the avatar ID. The avatar ID I believe is necessary to delete the avatar, but loading /settings/avatar/change
fetches the avatar again anyways, which will get the ID.
The call to /v1/profile
could return the avatar id to eliminate the necessity of fetching the avatar information again when hitting /settings/avatar/change
.
from fxa.
👍 to fix this, speed boost for functional tests :)
from fxa.
from mtg: the new spinner might make this experience better
from fxa.
We tested this in triage and I think it is fixed. A full refresh will show the settings page immediately with a blank avatar, and then the avatar is shown (after it downloads, presumably).
from fxa.
Related Issues (20)
- "Device Connected" page, the text on the button becomes unreadable blue-text-on-blue-background when clicked ("See tabs from synced devices") due to insufficient contrast HOT 6
- Cannot unsubscribe from Firefox Account Tips HOT 4
- Readme and documentation needs to use updated "Mozilla accounts" branding HOT 4
- Avatar is clipped on subscriptions page, due to explicit `w-16 h-16` classes HOT 4
- Subscription management page uses CSS file with broken/out-of-date source map HOT 1
- Layout shift after you open Bento Menu at top right of Mozilla Accounts page HOT 5
- The Sync sign-in success page just says "Sign in to this Firefox to complete set-up" without any other context (if you're not signed in) HOT 3
- The column of time/datestamps need a label/title to clarify their meaning, in the Connected Services section of settings
- On the "Approval now required" card at the end of the firefox.com/pair flow, the "from your other device" text is styled to be extra-small, despite being fairly-important HOT 1
- No graphic on on the "Approval now required" card at the end of the firefox.com/pair flow, HOT 2
- If the firefox.com/pair process times out and reaches "Pairing not successful", the user should be able to restart the pairing process with an offered button or link, or a reload HOT 2
- (l10n) - Duplicate string IDs
- Research @nx/playwright HOT 1
- accounts.firefox.com sends two HSTS headers HOT 5
- fxa-auth-server mock statsd lacks of function histogram
- (l10n) productPaymentCycleNew and productPaymentCycleOld are hard-coded to English HOT 1
- While subscriptions.firefox.com is loading, it shows a zero-height empty "card" while the loading throbber/spinner is still animating HOT 3
- communication on Firefox sync security level HOT 1
- [customs] RetryAfter not decreasing HOT 2
- Cannot set snsTopicArn to disabled in fxa-graphql-api HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from fxa.