Giter Club home page Giter Club logo

Comments (10)

sole avatar sole commented on June 9, 2024

Great idea! I'd like to see stylus in action too. I can help with this if you need any extra pair of eyes/hands.
Or maybe even documenting how to build-is the current sass step documented anywhere? I didn't see it in the Makefile.

from brick.

potch avatar potch commented on June 9, 2024

@ldoubleuz I'd love to get your okay on this before we go forward!

from brick.

fwenzel avatar fwenzel commented on June 9, 2024

Stylus would have the added beauty of economies of scale from other teams at Mozilla (most notably, Marketplace) also using it. This overlap can be helpful.

@sole I'm afraid I can only let you lend your eyes OR hands to this bug, not both. 😆

from brick.

ldoubleuz avatar ldoubleuz commented on June 9, 2024

@potch Sure thing! I'm okay with converting to using Stylus to simplify the build stack.

from brick.

potch avatar potch commented on June 9, 2024

Sweet, going to get cracking on this immediately.

from brick.

potch avatar potch commented on June 9, 2024

I have some strawman stuff hanging out over here: https://github.com/mozilla/brick/compare/stylus Not ready for merge yet, but would love feedback. Going to change the name of foundation as there's an established CSS framework with that name.

from brick.

pennyfx avatar pennyfx commented on June 9, 2024

@potch It looks like this creates a Brick dependency in the Calendar by having to reference ../../../mixins, etc..

If we break the common styles into another repo and use Bower, then the stylus import becomes ../bower_components/brick-common/mixins. This allows the element to be built in isolation and all dependencies are local to the element. This is how js and css dependences are already handled on every component at github.com/x-tag/.

Another benefit of having these styles in a repo is that contributors can easily clone them and come up with their own styles without having to clone all of Brick. We could essentially create skin packs like this and one could choose a skin pack by running something like bower install ffos-skin-silver, then run a build command.

What do you think?

from brick.

potch avatar potch commented on June 9, 2024

@pennyfx totally. I just placed those files in that location for the purposes of getting this started. When things are split up that approach makes complete sense.

from brick.

navaru avatar navaru commented on June 9, 2024

I would suggest to use visionmedia/rework instead of stylus, it offers greater flexibility.

from brick.

potch avatar potch commented on June 9, 2024

Fixed by 2b267ee.

from brick.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.