Comments (10)
Great idea! I'd like to see stylus in action too. I can help with this if you need any extra pair of eyes/hands.
Or maybe even documenting how to build-is the current sass step documented anywhere? I didn't see it in the Makefile.
from brick.
@ldoubleuz I'd love to get your okay on this before we go forward!
from brick.
Stylus would have the added beauty of economies of scale from other teams at Mozilla (most notably, Marketplace) also using it. This overlap can be helpful.
@sole I'm afraid I can only let you lend your eyes OR hands to this bug, not both. 😆
from brick.
@potch Sure thing! I'm okay with converting to using Stylus to simplify the build stack.
from brick.
Sweet, going to get cracking on this immediately.
from brick.
I have some strawman stuff hanging out over here: https://github.com/mozilla/brick/compare/stylus Not ready for merge yet, but would love feedback. Going to change the name of foundation
as there's an established CSS framework with that name.
from brick.
@potch It looks like this creates a Brick dependency in the Calendar by having to reference ../../../mixins, etc..
If we break the common styles into another repo and use Bower, then the stylus import becomes ../bower_components/brick-common/mixins. This allows the element to be built in isolation and all dependencies are local to the element. This is how js and css dependences are already handled on every component at github.com/x-tag/.
Another benefit of having these styles in a repo is that contributors can easily clone them and come up with their own styles without having to clone all of Brick. We could essentially create skin packs like this and one could choose a skin pack by running something like bower install ffos-skin-silver
, then run a build command.
What do you think?
from brick.
@pennyfx totally. I just placed those files in that location for the purposes of getting this started. When things are split up that approach makes complete sense.
from brick.
I would suggest to use visionmedia/rework instead of stylus, it offers greater flexibility.
from brick.
Fixed by 2b267ee.
from brick.
Related Issues (20)
- TabView component for Brick 2.0 HOT 3
- dist folder contains old brick-common HOT 1
- brick-form is missing from dist folder HOT 1
- update readme to include all components HOT 1
- Can I use brick without bower? HOT 4
- minified version is not working; templates need IDs
- Interdependece of components triggers a double registration element error HOT 1
- Semibreakage in Firefox OS HOT 5
- Please add an info that Brick do not work from file:/// HOT 5
- gulp server does not exist HOT 2
- Site doesn't load on iOS (nor on desktop Safari) HOT 1
- Ditch Shadow DOM and HTML Imports in the name of compat? HOT 8
- Code citations
- Brick Docs Responsive Layout Example
- Brick-common has a script directory
- [1.0.1] Attribute target disappears from element <a> when page is loaded
- Unminified Platform.js
- brick sites are invisible under safari
- Create Brick's like components and easy data-binding
- CDNJS hosting
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from brick.