Does Bramble support resolving one field from multiple federated services? about bramble HOT 8 CLOSED

@harshmttl @ihac we're currently working on fixing a number of issues related to this. We'll release a new Bramble update in a week or two that should solve this.

from bramble.

Hi @ihac

This should work, bramble currently has no protections against query complexity other than a timeout on execution time, so recursing down to dependent services should be fine.

I'm assuming you've cut out the fields on Query for looking up the @boundary types in the example schemas.

Can you share these example services so we could run a test with them?

from bramble.

Hi @pkqk here is the repo: https://github.com/ihac/graphql-poc-playground/tree/master/bramble-federation if you wanna run a test.

And below are some failed queries (we expected them to work though):

query {
  randomContentWithScoreCard { # resolved by content service.
    id
    title
    score { # resolved by social service
      teamAScore
      teamBScore
      ads { # should be resolved by ads service
        id
        message # cannot query field "message" on type "TinyAdsBanner"
      }
    }
  }
}

# Same issue as above
query {
  masthead_v2(count: 10) { # resolved by masthead service
    __typename
    contentItemsWithScoreCard { # resolved by content service
      id
      title
      score { #should be resolved by social service
        id
        teamAScore # cannot query field "teamAScore" on type "ScoreCard"
      }
    }
  }
}

Also, we tried the federation on union types, but it didn't seem to work. Is this as we expected as well?

query {
  masthead(count: 5) {
    __typename
    ... on ContentItem {
      id
      title
    }
    ... on ContentItemWithScoreCard {
      id
      title
    }
    ... on ScoreCard {
      id
    }
  }
}

The query above even caused a panic in Bramble: runtime error: invalid memory address or nil pointer dereference when it tried to marshal the result into response.

Thanks for help and also your great work!

from bramble.

Any updates here?

from bramble.

To clarify – the issue title questions the support for multi-sourcing field across schemas (which is slightly inconvenient but not really broken), whereas the issue discussed here (that I also quickly ran into) is with graph traversal. The traversal issue is in the works?

from bramble.

@ihac – I suspect that your report about abstract type failures (unions) may be related to #81 based on your query. I haven't been able to trigger panic, but panic itself may be a side effect of your logging.

from bramble.

@ihac — the original issue that you reported with deeply-nested fields not delegating properly was a big problem that I also ran into quickly. There’s a fix in the works here #85.

from bramble.

@gmac Thanks for the quick fix. Yes the issue title might be ambiguous as we're actually discussing about the graph traversal here.

As for the panic, it happened only when we queried the federated union types. I'll try once again to see whether I could reproduce it with your recent patches included.

from bramble.