full test coverage about postgres-operator HOT 6 OPEN

I've been thinking about this as well. This will be a bit tricky as most of our business logic depends on a database being there and is PostgreSQL specific.

Do you have any plan of attack?

from postgres-operator.

For operator controller(s) logic, we could use mocked PG package, which we could generate. As for the actual Postgres package, we'd have to use integration tests, running tests in docker-compose where we could use real postgres database, in a container. Another and probably easier option would be to use github actions as it supports services (like Gitlab CI Services), where we could configure something like this for integration tests:

jobs:
    services:
      postgres:
        image: postgres:10.8
        env:
          POSTGRES_USER: postgres
          POSTGRES_PASSWORD: postgres
          POSTGRES_DB: postgres
        ports:
        - 5432:5432
        # needed because the postgres container does not provide a healthcheck
        options: --health-cmd pg_isready --health-interval 10s --health-timeout 5s --health-retries 5

Which oiption do you prefer? This will not be easy as for some queries we'd need to write more queries in tests to check if it worked or not.

from postgres-operator.

Obvious first step would be to unit test the controllers' logic. There's even documentation on this from operator-sdk.

I'm fine with either option of integration tests. The github actions sounds really nice but we'd probably also need a way of running them locally.

from postgres-operator.

from postgres-operator.

I'm splitting this issue in two as it's quite big. One will be for unit and another for integration tests

from postgres-operator.

All work for this issue to be tracked in #32 and #33.

from postgres-operator.