Comments (4)
arnarg
commented on June 20, 2024
@hitman99 I'm having a bit of trouble with this like the issue is worded now.
Bool properties in golang will always (as far as I'm aware) default to false when using json unmarshal. Thus it's quite difficult to see if the user left the field unspecified or he set it to false on purpose.
I say we turn the wording around, like dropOnDelete or something like that. What do you think?
from postgres-operator.
hitman99
commented on June 20, 2024
@arnarg I see your point. Reword sounds the property as you suggested seems a good way to workaround it. In addition, we could look into defaulting
from postgres-operator.
arnarg
commented on June 20, 2024
In addition, we could look into defaulting
Yeah I noticed that in the documentation as well when researching this but it's currently in beta and only in 1.16.
The only other way I can think of is to use mutating admission webhook but I think that adds too much complexity for one boolean variable.
from postgres-operator.
hitman99
commented on June 20, 2024
Yeah, it's only beta in 1.16. For now your suggestion seems to be the best (rewording the property).
from postgres-operator.
Related Issues (20)
- Create a ConnectionString in the secret
- Add operator user to created roles by default
- Kustomization not using the new Google Image Repository
- Postgres User reconciller error loop when DB deleted manually - still having this problem in 1.2.1
- When postgres CR deleted before postgresusers CR it makes postgresusers finalizers to fail
- Schema creation failing HOT 15
- ARM support HOT 1
- Cannot create a database with customized `locale` and `encoding` options
- cannot terminate database with open connections
- Helm Chart should come with .image.tag set to an empty string in values.yaml
- The role-reader and role-writer do not have the appropriate permissions. HOT 8
- [Question]: Multiple RDS/Database instances HOT 1
- Add PostgresSchema CR
- Hash suffix to usernames
- [Feature] Allow connection with certificate
- POSTGRES_URI_ARGS applied to operator don't apply to generated secrets
- Failure to Cleanup Finalizers on Shutdown HOT 1
- postgres connection limits
- POSTGRES_URL should contain POSTGRES_URI_ARGS HOT 2
- RBAC is spooooooky HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from postgres-operator.