Dynamic Time Warping about movetk HOT 7 OPEN

@mstroila , I remember you had started looking into this. Whenever you have time if you can please checkin what you have and we can take it from there

from movetk.

@mstroila can you please sign the comment messages as git -s -m . This will ensure that the DCO check passes and will also allow you to merge to the master once the changes to the branch are finalised

from movetk.

@mstroila can you please sign the comment messages as git -s -m . This will ensure that the DCO check passes and will also allow you to merge to the master once the changes to the branch are finalised

Got it, thanks, I fixed the previous commits and will sign off from now on.

from movetk.

@mstroila we made some changes due to Issue #33 and pushed to master.

Maybe its a good idea to pull from master so that the fix does not adversely impact your implementation

from movetk.

@mstroila we made some changes due to Issue #33 and pushed to master.

Maybe its a good idea to pull from master so that the fix does not adversely impact your implementation

I tried that and got lots of conflicts in the docs folder. I noticed that the ci builds docs outside of the build folder (Release). I think ci should build docs in the build folder, correct? @aniketmitra001 , do you agree, and if so should I create an issue for this?

from movetk.

@mstroila we made some changes due to Issue #33 and pushed to master.
Maybe its a good idea to pull from master so that the fix does not adversely impact your implementation

I tried that and got lots of conflicts in the docs folder. I noticed that the ci builds docs outside of the build folder (Release). I think ci should build docs in the build folder, correct? @aniketmitra001 , do you agree, and if so should I create an issue for this?

@mstroila , for now please allow the changes in the docs of master to overwrite the changes in docs on your branch. Then once you rebuild your branch docs from your branch will be regenerated.
Yes, I agree that we need a better solution for this. The initial design was to only generate docs during the build process with the CMAKE flag BUILD_DOC. During the open sourcing process we were told that the docs folder(if at all present) cannot be empty and should contain the necessary documentation html files. Also if documentation needs to be served on GitHub Pages / movetk.win.tue.nl/ , it needs to be placed somewhere, maybe on a separate documentation-branch?
But off-course the way it is now is not nice and is making a mess of the merge process. Please create an issue for the same. We will think of a solution and fix this

from movetk.

@mstroila please see this for the requirement to move the DTW implementation code from GeometryInterface to a separate file

from movetk.