Comments (2)
From our experience, labels like the ones you suggested quickly become out of date. For example, as soon as someone does a review, they must also remember to remove that label. Instead, we typically just use "WIP" in the title of the PR, which you can easily do through the Github web interface.
Overall, let's just focus on merging PRs quickly so that we don't need labels.
from moveit2.
I can't say I agree with this. It certainly will help the reviewing process of the PRs and facilitate our work. Every time I open the PRs I need to manually navigate through them to get an intuition of what's requested and the status of it. Some simple labeling would help very much. I'm happy helping maintain this.
Overall, let's just focus on merging PRs quickly so that we don't need labels.
I understand this is the philosophy but it's not what's happening. We have PRs with 60+ comments, several of which pointed towards actions that weren't compiling or points discussed in other issues.
Please reconsider it.
from moveit2.
Related Issues (20)
- setup_assistant launch files don't work HOT 4
- Broken `https://moveit.ai`?
- moveit_py -> use_sim_time: True fetching Error rclcpp::exceptions::InvalidParameterValueException
- Fix duplication of Pilz motion sequence trajectory points... the right way
- MoveIt logo at top of README is a broken link HOT 1
- typo "trajactory" in moveit_py HOT 2
- KDL IK Solver with SVD HOT 1
- Servo cannot reach the desired control rate HOT 4
- An early call to `planning_scene_monitor_->getStateMonitor()->getCurrentState()` returns `nan` accelerations
- Segfault in Depth Image Octomap Updater Plugin HOT 1
- Couldn't load kinematics.yaml when using hybrid_planning_demo_node.cpp
- Change the starting point of planning under the plug-in using a topic or service HOT 8
- Moveit Setup Assistant crashes in Robot Poses tab HOT 4
- executable 'servo_node' not found on the libexec directory HOT 6
- Pressing backspace on the first page of the MoveIt Setup Assistant crashes the application
- No kinematics plugins defined. Fill and load kinematics.yaml! HOT 6
- Adding MoveIt2 #include's stop VS Code Intellisense from working HOT 2
- Humble MoveIt2 Moveit_servo HOT 2
- RViz ignores 'joint_limits.yaml' in MoveIt Config when using moveit_rviz default launch file
- Isaac Panda Hand Controller Issue
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from moveit2.