Giter Club home page Giter Club logo

Comments (5)

alpha-baby avatar alpha-baby commented on August 28, 2024 1

参考go标准库升级http.Do的方式,可以把context放进结构体里 https://go.dev/blog/context-and-structs

https://github.com/mosn/mosn/blob/42c4dc0563480a508822b1e106dac789732d5eab/pkg/upstream/healthcheck/session_checker.go#LL162C22-L162C33

CheckHealth 方法

这个方法是无参的

from mosn.

alpha-baby avatar alpha-baby commented on August 28, 2024

@doujiang24 @taoyuanyuan

from mosn.

doujiang24 avatar doujiang24 commented on August 28, 2024

感觉可以试试看的

from mosn.

alpha-baby avatar alpha-baby commented on August 28, 2024

感觉可以试试看的

如果直接在 CheckHealth 方法上加上一个入参 ctx 会破坏兼容性,如果要做一个好的兼容性的话,是不是可以新开一个 接口,比如叫:HealthCheckSessionV2,

或者还有其他比较好的方式吗?

from mosn.

zlasd avatar zlasd commented on August 28, 2024

参考go标准库升级http.Do的方式,可以把context放进结构体里 https://go.dev/blog/context-and-structs

from mosn.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.