Comments (2)
Integration with travis testing LTS and stable versions of node
It was using our old internal CI, but we moved it and some of our OS projects weren't updated, used Travis instead.
a code convention definition
I can help with that if you agreed
If you may help us here it would be great!
We like to:
- use
var
declarations on every vars instead of aggregating them (we didn't have this before, we added it since its easier to manage them. - avoid
;
, since javascript hasasi
- spaces instead of tabs (we use 4)
- spaces, spaces and more spaces: code should be readable, by any one.
// Instead of:
if('some'=='condition'){
return 'yolo'
}
// We prefer:
if ( 'some' == 'condition' ) {
return 'yolo'
}
- brackets, always write them on ifs, even that you just want to return. (this allows anyone to fastly change code without having to break lines, identate, and so on.
// Instead of:
if ( condition ) return
// We prefer:
if ( condition ) {
return
}
Better code readability I.E by replacing magic numbers with constants.
Agree. Do you have some suggestion regarding a new folder structure having in mind a file for constants?
from proxywrap.
I'm going to open different PR for each item so we can discuss each thing in a separate thread
from proxywrap.
Related Issues (20)
- Sockets are leaking HOT 3
- Check for Header consistency HOT 2
- Not working at all on node 0.12.2 HOT 21
- Socket.Io running HTTPS behind AWS ELB HOT 14
- Catching the PROXY protocol error HOT 23
- TCP port are from 1 to 65535 and not from 1 to 65335 HOT 3
- Under stress, some connections keep open HOT 5
- Unable to mix proxied and unproxied services? HOT 2
- Proxy protocol version 2 HOT 4
- Can't detect Socket.io 'disconnet' event when using via Amazon ELB HOT 4
- Is proxywrap working properly with https module? HOT 5
- proxy protcol v1 or v2
- TypeScript support
- Does this work with Node v12 LTS and HTTP/2? HOT 3
- Thank you HOT 1
- Elaborate and explain why it poses a security risk in README HOT 3
- Error when starting HOT 1
- BSD license with dependency on GPL-3.0 findhit-util HOT 2
- is it support outgoing proxy ?
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from proxywrap.