Comments (3)
I think we could resolve this in roll_repository_directories()
by setting keep_through
to tomorrow's date if config_keep_days
is greater than the number of days in the previous month. I need to verify this.
We should be able to determine the number of days in the previous month, by selecting the first day of the current month and using adjusting -1 days. This might require implementing changes to reldate()
or an entirely new method.
from 43f.
I believe my previous note about this occurring when config_keep_days
is greater than the number of days in the previous month was correct. I've implemented a fix in the too-few-days-data-kept-in-march
branch, which could use more testing. Specifically, if config_keep_days
is greater than the number of days in the previous month, then it just uses the number of days in the previous month in the calculation of the keep_through
day. I believe this to be safe.
To get to this fix, I've replaced the reldate()
function with a new relative_to_now()
function, which--in turn--is powered by a new relative_date()
function. There's also a new days_in_previous_month()
function which also uses relative_date()
. All of this relies solely on Dateutils (it' wasn't feasible without it), so I've noted that it is a requirement for all platforms.
from 43f.
I have reviewed this and still believe it to be safe and to fix the issue. I have merged the too-few-days-data-kept-in-march
branch into master.
from 43f.
Related Issues (20)
- Intermittent failure of it_does_not_move_files_modified_today_from_todays_directory test in roll_repository_directories() test suite on OpenBSD
- Intermittent failure of it_does_not_move_files_within_days_to_keep_directories test in roll_repository_directories() test suite on OpenBSD
- Failure of it_does_move_files_outside_days_to_keep_directories test in roll_repository_directories() test suite on OpenBSD HOT 2
- Failure of it_does_not_move_files_inside_months_to_keep_directories test in roll_repository_directories() test suite on OpenBSD HOT 1
- Failure of it_does_move_files_outside_months_to_keep_directories test in roll_repository_directories() test suite on OpenBSD HOT 1
- Increase readability of conditional statements HOT 2
- Installation overwrites existing 43f.conf file HOT 1
- `reldate: command not found` errors when running `43f stats` HOT 2
- Refactor verbose output lines HOT 1
- `sed` errors in Makefile on macOS 10.12 Sierra HOT 3
- `43f stats` tests are not compatible with OpenBSD HOT 1
- init_repository_symlinks() fails to correctly create symlinks when `dadd` is not in the path HOT 2
- Error in valid_month() in lib43f in month of August HOT 2
- Failing date format string related tests on macOS
- Failing it_does_move_files_outside_months_to_keep_directories() test in roll_repository_directories() test suite on macOS HOT 1
- Modified directory permissions are not retained when creating new subdirectories HOT 2
- load_config() fails to set config_notify_email if email address has long TLD HOT 1
- reldate() should return an error if format string doesn't start with a plus symbol HOT 1
- roll_repository_daily_to_monthly() should return false when given empty parameters HOT 1
- roll_repository_monthly_to_monthly() should return false when given empty parameters HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from 43f.