Giter Club home page Giter Club logo

Comments (3)

morellodev avatar morellodev commented on May 24, 2024 1

Hi Itay,

thank you for having written this issue so well! I will investigate and fix this unexpected behavior during the weekend, and a new release will be released soon.

Cheers

from react-awesome-reveal.

morellodev avatar morellodev commented on May 24, 2024

After reading this, I prefer not to handle refs internally and let the user take care of them. I think wrapping your custom components with a <div> is a reasonable trade-off.

from react-awesome-reveal.

itayganor avatar itayganor commented on May 24, 2024

Seems legit, but adding extra elements with no benefit rather than a compromised workaround is not a good practice. It means there's another div to be taken care of, in terms of CSS and layout, Adds complexity to an already complicated element tree, and just another "gotcha" for the library to warn about.

If you ask me, it sounds like a great reason to have a major bump.

from react-awesome-reveal.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.