System.InvalidCastException when invoking method that starts with "add" about moq4 HOT 8 CLOSED

I can reproduce this and have tracked it down to a problem with the way Moq detects event handler attach methods and other special method types. The key file is:
\Source\MemberInfoExtensions.cs - in this case Line 66

Methods called 'add__' and 'remove__' will not work, this is case sensitive hence why 'Add' works. We will need to try and find a better way to detect if something is an event handler attach call.

from moq4.

Maybe we can just try to cast and fallback to considering it a regular method oherwise?

from moq4.

Shouldn't that be checking IsSpecialName?

from moq4.

+1 to IsSpecialName. Shouldn't pass for a normal method named "add_*"

from moq4.

Why we should restrict users in their naming style(i have a lot of legacy code and it might be painfull to change restricted names)? Can we mark all special method types with some attribute?

from moq4.

it's been so many years and this has come up so rarely that I'd say it's a
corner case which we're fine not supporting. As long as we don't throw any
exceptions, it should be fine.

I recall now that we removed the check for IsSpecialName for compatibility
with F#. See
44070a9

The naming goes against anything in .NET conventions for public/protected
members, so I think it's reasonable to assume it won't be (and hasn't been)
a serious issue for most.

/kzu

Daniel Cazzulino

On Sun, Feb 9, 2014 at 11:56 PM, F0b0s [email protected] wrote:

Why we should restrict users in their naming style(i have a lot of legacy
code and it might be painfull to change restricted names)? Can we mark all
special method types with some attribute?

Reply to this email directly or view it on GitHubhttps://github.com//issues/82#issuecomment-34600996
.

from moq4.

Aha, I was mocking a web service with add_* method names and came across this issue :)

from moq4.

Regular methods with add_ or remove_ name prefixes are now supported in Moq 4.8.0.

from moq4.