Giter Club home page Giter Club logo

Comments (6)

jodal avatar jodal commented on July 21, 2024

Mopidy-Spotify 1.x requires pyspotify 1.x. Mopidy-Spotify 2.x requires pyspotify 2.x.

Any new development should happen on Mopidy-Spotify 2.x.

from mopidy-spotify.

jodal avatar jodal commented on July 21, 2024

To add a bit more detail: Mopidy-Spotify 2.x is close to a first release to PyPI. The current state of the develop branch is quite good. It depends on a feature of pyspotify that is not released yet, thus you need pyspotify 2 from git too.

As to adding features, discussing the feature and what it should do first greatly increases the odds for getting it merged. What kind of playlist configurations are you thinking about and what's their use cases?

It might be relevant that I've already added a new configuration in Mopidy-Spotify 2 for turning off playlists:

spotify/allow_playlists: Whether or not playlists should be exposed. Defaults to true.

from mopidy-spotify.

peterlvilim avatar peterlvilim commented on July 21, 2024

Thanks for quick response and explanation! Switching my branch to develop from master for mopidy-spotify solved my problem. I have pyspotify checked out and setup also right now.

I'll comment on the open issue for playlists with what I was thinking of doing.

from mopidy-spotify.

peterlvilim avatar peterlvilim commented on July 21, 2024

I'm reopening. The problem seems to be dependent on which artist you look up and the state of your cache, so I think I was a bit spurious in closing.

I'm using the develop branches for both mopidy-spotify and pyspotify. Believe the problem is in mopidy-spotify. I've opened a pull request with the area of code that I think is a problem.

A good way to illustrate the problem is to lookup an artist with a large number of albums. I'm using ncmpcpp. When I do a search for Avicii then select the artist to load all of the tracks for the artist into the now playing list MPD hangs for a very long time and ncmpcpp becomes unresponsive (I say very long because I haven't seen it return for over 1 minute+). Another artist that you could do would be Selena Gomez which hangs for about 10-15 seconds but does return (fewer albums I assume).

This problem doesn't happen when I use the pre-2.x version. I believe the problem is due to the new way that artist look ups are done is generating many queries. Believe my diff in the pull request and the attached comments should illustrate this.

Let me know if you can reproduce.

from mopidy-spotify.

modprobe avatar modprobe commented on July 21, 2024

I'm also seeing this behaviour and I think @peterlvilim is correct in his assumption. The changes made to fix #7 seem to be a very likely suspect.

from mopidy-spotify.

jodal avatar jodal commented on July 21, 2024

I can reproduce and agree with your conclusions. Closing this issue and continuing discussion in #31.

from mopidy-spotify.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.