Giter Club home page Giter Club logo

Comments (6)

jodal avatar jodal commented on July 21, 2024

Agree! Should do this differently for the upcoming Mopidy-Spotify 2.0.

from mopidy-spotify.

kingosticks avatar kingosticks commented on July 21, 2024

Do you think there is any merit in doing this in pyspotify 2.0? At least the exact searches bit.

I vaguely remember the mention of an additional higher-level wrapper that did some extra useful stuff (I think this was based around the bug where starred playlists have no name),

from mopidy-spotify.

jodal avatar jodal commented on July 21, 2024

It's worth considering at least. The immediate issue I can think of is how to make an "exact match" overlay over the existing search work nicely with pagination. If you search for "foo" and ask for 20 results, then you're told that "we found 73 results, here's the first 20" and then there's only 18 in the result, since two wasn't exact matches.

from mopidy-spotify.

trygveaa avatar trygveaa commented on July 21, 2024

mopidy/mopidy#272 seems relevant here. We should consider using artist/albumbrowse instead of or in addition to search for find_exact.

from mopidy-spotify.

jodal avatar jodal commented on July 21, 2024

To move the entire discussion over here, I'm quoting @trygveaa from mopidy/mopidy#272:

We can first do a search for the query provided. Then traverse either the artist or album results, depending on what the query contained, to find the one that matches exactly (this means that searches will have to be able to return artists and albums, as discussed in #285). At last we do a lookup of the artist or album to retrieve all the tracks.

The benefits of this vs. a normal search:

  • We are able to retrieve all the tracks from the artist or album, not just a matching subset of the max number of tracks returned by searches.
  • We won't have to do any filtering.

The disadvantage:

  • We have to do two queries to Spotify.

from mopidy-spotify.

jodal avatar jodal commented on July 21, 2024

From the discussion in mopidy/mopidy#727 it sounds like making exact searches exact would help on data quality in the ncmpcpp library view as well.

from mopidy-spotify.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.