Add support for user to set preferred audio quality about mopidy-pandora HOT 6 CLOSED

Thanks. Couple of comments:

• Add api_host to the README.rst sample config

• Make preferred_audio_quality schema optional and configure the choices, e.g.:

  schema['preferred_audio_quality'] = config.String(optional=True, choices=['lowQuality', 'mediumQuality','highQuality'])

• Is schema['api_host'] optional and does it have a default?

• Make both configs (api_host and preferred_audio_quality) optional when building settings, i.e. use config.get("preferred_audio_quality", 'mediumQuality')

from mopidy-pandora.

I've implemented the changes - thank you.

api_host is optional as the changes proposed in mcrute/pydora#2 contain defaults for this configuration setting as well. Just for reference: the available api host urls are listed at the top of the specification at http://6xq.net/playground/pandora-apidoc/json/

It will only ever be necessary to change api_host when using a Pandora One account, in which case using internal-tuner.pandora.com/services/json/ may be preferable. I'm not sure we should list the configuration choices in the schema as they can only be used with specific permutations of the other partner_ settings.

from mopidy-pandora.

I've created the pull request so long (#3)

from mopidy-pandora.

Just a note that the required changes to pydora were recently merged, and are now contained in release 0.2.3.

@rectalogic, would you mind taking a look at #3 when you are ready and let me know if you encounter any issues?

from mopidy-pandora.

Merged #3

from mopidy-pandora.

I forgot to increment the required version number of pydora - please take a look at #5

from mopidy-pandora.