Giter Club home page Giter Club logo

Comments (5)

MoonStorm avatar MoonStorm commented on August 20, 2024

I think you're on to something here. Basically your entity has no key properties generated by the database but you do have non-key db generated columns. This looks like a missed case and does require extra code. Currently the code creates SQL that relies on LAST_INSERT_ID() to fetch the db generated columns, which in your case makes no sense.

from fastcrud.

CameronFiederer avatar CameronFiederer commented on August 20, 2024

Given the right conditional statement, could something like this work to construct the select statement?

sql += $"SELECT {databaseGeneratedColumnSelection} FROM {this.GetTableName()} WHERE" + this.ConstructKeysWhereClause(this.GetTableName())

from fastcrud.

MoonStorm avatar MoonStorm commented on August 20, 2024

I don't think ConstructKeysWhereClause requires an alias but other than that it looks good. Could you create a PR? We're in the middle of the beta for 2.4.0 so this one couldn't have come at a better time.

from fastcrud.

CameronFiederer avatar CameronFiederer commented on August 20, 2024

Probably should have mentioned that I already started on it tonight: #35.

from fastcrud.

MoonStorm avatar MoonStorm commented on August 20, 2024

Thanks for providing a fix. The existing tests all passed and a preview package is available on nuget.

from fastcrud.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.