I cant Download the QR about angular-qrcode HOT 12 CLOSED

I have same issue, did not get solution

from angular-qrcode.

you can do what I did as well...

Look, put a download button and give it an id, then go to the script and in the part where the script asign the download URL you can pass it trough DOM elements managements and then the image will be downloaded.

from angular-qrcode.

same issue ...
Found that problem is caused by loosing pointer to DOM on this part of code (line 129)

if (link) {
          link.className = 'qrcode-link';
          $canvas.wrap(link);
          domElement = link;
        }

main problem is on domElement = link

Overhead is set it to this way domElement = element[0].firstChild

if (link) {
          link.className = 'qrcode-link';
          $canvas.wrap(link);
          domElement = element[0].firstChild;
        }

from angular-qrcode.

interesting @kodl, those 2 code examples should be equivalent, and download does works for me here (in chrome) without this fix:

http://monospaced.github.io/angular-qrcode/

do you have any more info on your setup, is it a particular browser you're experiencing this issue in?

from angular-qrcode.

Same issue here. @kodl is right. After $canvas.wrap(link), the 'link' is no longer the same 'link'.
However the demo link works fine for me too.

from angular-qrcode.

Different Angular version? I'm using Angular 1.3.18

from angular-qrcode.

Angular-qrcode is part of my (bigger project) - I didn't tested the plain component separately (yet) .. On project I'm using "angularjs": "~1.3.17" and tested it on Chrome 45.0.2454.101, iPhone Safari and Android Chrome.

When I've debug it I found, that variable domElement contains element with correct href, but it isn't in the DOM - in DOM was cloned element without href. Seems that $canvas.wrap(link) create (for some reason) a copy of element and wrap it around canvas, but return original element which is unattached to DOM (classname is set to 'qrcode-link' on both instances).

I'm going to test it on separate project (on the demo code) .. but currently I'm out of time .. :(

from angular-qrcode.

Thanks everyone 👍

My conclusion is that the behaviour of angular.element.wrap() changed between Angular 1.2.10 and 1.4.7.

Should be fixed in c8cf213, and new version 6.1.3 released.

from angular-qrcode.

Actually looking at the comments here and #24, the behaviour of wrap() must had changed by Angular 1.3.x.

from angular-qrcode.

👍 Thank you for quick fix

from angular-qrcode.

Thank very much for fixing it :)

from angular-qrcode.

fixed

from angular-qrcode.