Version Numbers about licenseplist HOT 6 CLOSED

Apologies, yeah this is all good!

from licenseplist.

Agreed with the off by default and maybe --add-version-numbers as the flag
If it's a commit hash (which my regex doesn't detect) it should probably show the first 7 characters (as per normal standards)

With regards to GitHub, we could add more purpose to the rename functionality, or simply add a colon to what they already have making it:

github:
  - account/library:
    - version: 1.0.0
  - account/otherlib

from licenseplist.

@mono0926
So had a quick look at CocoaPods (I don't work much with Carthage) and its clear the they don't store the version in the acknowledgements.plist file that you currently read from.

With that in mind there would have to be an extra step which parses either the Podfile.lock or Pods/Manifest.lock creating a dictionary for name to version (I've created a regex which can do this: -(.*)\(([0-9.]*)\), it creates two groups the first being the name and the second being the version).

With that dictionary at hand it would be quite easy then iterate through the licenses that you have, check if that license name is within the dictionary and then bind the version number

from licenseplist.

@Sherlouk

Thanks, Carthage and CocoaPods both would be okay and thanks for the regex.

For github config, I haven't made up my mind.

This is not valid YAML(You can confirm it at Online YAML Parser).

github:
  - account/library
    version: 1.0.1

This is the example of valid format.

github:
  - owner: account
    repo: library
    version: 1.0.1
  - account/library # also support current format

Or you can specify the version by using the rename config.
So, github version specification may not be needed to support.

rename:
  library: library (1.0.1)

• If specified by commit hash on Podfile or Cartfile, how to treat it?
• I think version numbers should be off by default, so what is the flag name to turn of the feature?
  • ---version-number ?

from licenseplist.

@Sherlouk

I implemented( https://github.com/mono0926/LicensePlist/releases/tag/1.3.0 ).

For github YAML, I adopted this format:

I considered your proposal, but I adopted above format because its list/dictionary structure is more natural I think.

from licenseplist.

@Sherlouk

May I close the issue?

from licenseplist.