Tmp file are not deleted if sheet not found. about excel-streaming-reader HOT 6 CLOSED

Ah, I see. I'll get that fixed when I get off work. I'll also have that code throw a more meaningful exception type.

from excel-streaming-reader.

Just released a new version to Maven Central with the fix. Let me know if you're seeing a temp file hanging around.

from excel-streaming-reader.

Perfect it solves.

But i think, you can can make these calls to f.delete() parameterized (.deleteFileOnError(true|false)) like your params of buffer size.
Or you can put the f.delete() only on catchs from method read(InputStream is).

Because to my case i want to delete malformed files provided by ImputStream, but the public method read(File f) can be reciving an direct (and very important) file from consumer aplication and if it get an exception this file will be deleted.

I do not want you to be cursed because of me. If any developer pass an important file directly and put a wrong sheet name accidentally.

In advanced. Thanks for fast response.
Great Job...

from excel-streaming-reader.

Oh jeez, I see what you mean. I'll get that fixed right away.

from excel-streaming-reader.

Released a new version to Maven Central with that issue resolved and a unit test to make sure the read(File) option doesn't delete anything it shouldn't.

from excel-streaming-reader.

Yeah all right now.

Thanks again...
closing issue...

from excel-streaming-reader.