Currently all field generators check if field is or not required except for FileField

field_generator ignores required property of FileField and ImageField. about django-mongoengine HOT 4 CLOSED

mongoengine commented on June 12, 2024

field_generator ignores required property of FileField and ImageField.

from django-mongoengine.

Comments (4)

fmoro commented on June 12, 2024

OK, that don't solve the problem, I will continue investigating.

from django-mongoengine.

last-partizan commented on June 12, 2024

BTW, are you testing everything on your own app or example/tumlelog app?

I just tried to use example and looks like everything is broken. Trying to fix.

from django-mongoengine.

fmoro commented on June 12, 2024

Yes, I am testing everything on my oun app.
I know that example app doesn't work... :P

from django-mongoengine.

fmoro commented on June 12, 2024

Ok, with this patch it works as expected. If a FileField (or ImageField) is required, it will be required for save the object, but if this object already has a file you don't have to upload it again since there is one already.

diff -rupN django-mongoengine.orig/django_mongoengine/forms/field_generator.py django-mongoengine/django_mongoengine/forms/field_generator.py
--- django-mongoengine.orig/django_mongoengine/forms/field_generator.py 2015-09-23 16:28:34.090070123 +0200
+++ django-mongoengine/django_mongoengine/forms/field_generator.py  2015-09-24 09:58:35.010007575 +0200
@@ -258,10 +258,24 @@ class MongoFormFieldGenerator(object):
             return f

     def generate_filefield(self, field, **kwargs):
-        return forms.FileField(**kwargs)
+        form_class = forms.FileField
+        defaults = {
+            'required': field.required,
+            'label': self.get_field_label(field),
+            'help_text': self.get_field_help_text(field),
+        }
+        defaults.update(kwargs)
+        return form_class(**defaults)

     def generate_imagefield(self, field, **kwargs):
-        return forms.ImageField(**kwargs)
+        form_class = forms.ImageField
+        defaults = {
+            'required': field.required,
+            'label': self.get_field_label(field),
+            'help_text': self.get_field_help_text(field),
+        }
+        defaults.update(kwargs)
+        return form_class(**defaults)

     def generate_dictfield(self, field, **kwargs):
         #remove Mongo reserved words

from django-mongoengine.

Recommend Projects