Wallet RPC : Mismatched txids when processing unconfimed txes from pool about nodejs-pool HOT 8 CLOSED

This issue : monero-project/monero#2386 . It got fixed in Monero, how can I apply to Electroneum :(

from nodejs-pool.

@MoneroOcean For etn.js, there is if (body.fee && body.fee > 10), do I need to change it ? Do you know what this if means and why 10 ? With ETN it triggers else "Unknown error ..." even the payment transaction is passed.

from nodejs-pool.

I afraid I will not be able to help here. First of all I do not want to support ETN code and second thing is that I prefer to keep away from this sensitive part of pool code (leaving its support to Snipa). I can only guess that body.fee > 10 is just a extra check against some garbage output from wallet. Fee here is integer number that should be divided by huge 1000... to get value in XMR and it I guess Snipa decided that it can't be less than 10 under any normal circumstances. Maybe for ETN normal fees can be less than 10 here.

from nodejs-pool.

Great help. Your explanation seems very correct. Thank you alot.

from nodejs-pool.

Just stumbled upon relevant commit that contains some explanations that can help you (if you still need help here of course): Snipa22@5d31708

from nodejs-pool.

Thanks to your suggestions, I fixed it by myself. The ETN has only 100 atomic units, so I correct it by body.fee > 0.0000001 ( whatever number that is smaller than 1 should work, I think I can put this part away because fee = 1 is possible with ETN ). At the moment, I got only issues with all rows with fee type (pool, dev, poolDev) are always zero in balance. I think pehaps because of 100 atomic units but I see all codes look fine. I can’t debug directly with my pool ( The miners are mining at pool and I’m promoting it ). In the short term, pool with 0% fee is all right. I’ll look at your fix, I think your fix is better, thank you 👍

from nodejs-pool.

if (body.fee && body.fee > 10) {
—> if (typeof body.tx_hash !== 'undefined') {

What if body.tx_hash is NULL ?, I’m not coders so sometimes I can ask noob questions ?
If I apply this fix to my AEON pool (aeon.js), which modules do I need to restart ?

from nodejs-pool.

For info, I understand it now, it's for DEFAULT_DUST_THRESHOLD as you guessed. You are correct !!!

from nodejs-pool.