long runner about nodejs-pool HOT 8 CLOSED

So the problem is that it can remove shares that are still required for payment calculations, right?
Is it only a problem for PPS?

from nodejs-pool.

yes
for pplns too

from nodejs-pool.

I actually also have reports that it can happen from hashvault pool operator as well, so I believe there must be something wrong with this or related code. Maybe not in the getOldestLockedBlock function but later. Will take a closer look.

from nodejs-pool.

Or maybe do you have debug info? You mentioned that the problem was detected by you in this line:

callback(null, body.height - Math.floor(global.config.payout.blocksRequired/2), Math.floor(body.difficulty * global.config.pplns.shareMulti * 5));

This is actually PPS case, right? And it really does not depend on oldestLockedBlock.height here, so can you please provide more observations if possible?

from nodejs-pool.

Sorry i have
function(oldestLockedBlock, callback){
global.coinFuncs.getLastBlockHeader(function(err, body){
if (oldestLockedBlock === null){
if (global.config.pps.enable){
callback(null, body.height - Math.floor(global.config.payout.blocksRequired/2), Math.floor(body.difficulty * global.config.pplns.shareMulti * 5));
} else {
callback(null, body.height, Math.floor(body.difficulty * global.config.pplns.shareMulti * 5));
}
} else {
if (global.config.pps.enable && oldestLockedBlock.height > body.height - Math.floor(global.config.payout.blocksRequired/2)) {
callback(null, body.height - Math.floor(global.config.payout.blocksRequired/2), Math.floor(body.difficulty * global.config.pplns.shareMulti * 5));
} else {
callback(null, oldestLockedBlock.height, Math.floor(oldestLockedBlock.difficulty * global.config.pplns.shareMulti * 5));
}
}
});
},

I have pplns mode enabled
and there were a couple of times so that there were 15 blocks locked and it took the block in the middle and counted the buffer and the rest was removed and the pplns payment passed with 0%

from nodejs-pool.

Thanks! That's definitely helpful.

from nodejs-pool.

I put guards for that issue (it does not belong to performance critical path, so it is OK to have to extra check here) and some additional related fixes to avoid important share removal:

5ae1401

I already applied that to MoneroOcean pool. Nothing bad happened at least after the first share cleanup.

from nodejs-pool.

Cool thanks. I try it.

from nodejs-pool.