Comments (1)
<rbrunner7> Meeting time. Hello! https://github.com/monero-project/meta/issues/982
<rbrunner7> Can you please add "reading" to your hello
<rbrunner7> so I know who can read me and who probably not
<dangerousfreedom> Hello. I can read you now :)
<jberman> *waves*
<rbrunner7> jberman: Can you read me?
<SNeedlewoods> hey, I joined IRC so hopefully see the best of both worlds
<sneedlewoods_xmr> hey
<rbrunner7> Perfect, SNeedlewoods . That probably works.
<SNeedlewoods> rbrunner your message didn't come through to matrix side
<jeffro256> Howdy
<sneedlewoods_xmr> jberman can you join irc? message from rbrunner does not show here
<jeffro256> I'm joining from IRC since monero.social -> matrix.org Matrix messages don't work
* jberman (~jberman@2001:41d0:a:2aab::1) has joined
<rbrunner7> jeffro256: Do you see what I write as "rbrunner7" on Matrix?
<jberman> *waves from irc*
<jberman> I don't, I only see sneedlewood's message
<rbrunner> jeffro256: Do you see what I write as "rbrunner7" on Matrix?
<dangerousfreedom> I only changed the server to monero.social and now I can see the messages
<jeffro256> rbrunner7: yes, but i'm on the monero.social server
<rbrunner> So maybe better I also use IRC for today?
<rbrunner> Alright, seems more or less ok then to start.
<rbrunner> What is there to report from last week?
<dangerousfreedom> This week I could advance in putting everything together (EnoteStore, TxHistory, KeyContainer) and created a demonstrator of a wallet. The goal was to make a few transactions between two wallets, retrieve the proper balance, show the enotes and make knowledge proofs on them. Here it is:
<jeffro256> Holy moly that's awesome !
<dangerousfreedom> I would like to kindly ask your feedback about the way things are going. I believe this could really look like a version0_pre_alpha_proto seraphis wallet :p
<jeffro256> How were transactions transmitted?
<system> file Screencast from 25.03.2024 18:21:17.webm too big to download (17663360 > allowed size: 1000000)
<dangerousfreedom> Screencast from 25.03.2024 18:21:17.webm
<SNeedlewoods> I got feedback from koe and jberman and worked on https://github.com/UkoeHB/monero/pull/40
<SNeedlewoods> but currently my local branch is quite messy and I introduced bugs I need to fix, can still push if someone wants to see?
<dangerousfreedom> Of course there are really a lot of things to do like:
<dangerousfreedom> - Use the proper KeyContainer. Right now I'm using the previous version of seraphis and waiting for ghostway KeyContainer.
<dangerousfreedom> - Update everything (address scheme, knowledge proofs, etc) with the jamtis updates proposed by jeffro256
<dangerousfreedom> - Use a real ledger instead of the `MockLedgerContext`. Some comments here:
<dangerousfreedom> - Right now I'm de/serializing the MockLedgerContext to have a local permanent storage. This is not optimal, it is buggy now but it allows to test many wallet functions. (Thanks to Koe and his modular library design).
<dangerousfreedom> - Only the storage of seraphis enotes is working now. I will try to fix the serialization for the legacy ones next and try to incorporate the legacy scanner from jberman
<jberman> Update: the async wallet scanner is now backwards compatible with today's node versions, scanning perf is on par with wallet2 today when pointing to a current node (the async scanner's significant speed-up requires the daemon to update). I'm currently wrapping up the PR with final touches, cleaning up class structure/naming/commit history etc.
<jberman> Shooting for ready-for-review this week
<SNeedlewoods> before that I started this https://github.com/UkoeHB/monero/compare/seraphis_lib...SNeedlewoods:seraphis_wallet:x_identify_edge_cases
<dangerousfreedom> I'm serializing the MockLedgerContext and loading/saving it everytime I open/close a wallet
<rbrunner> ghostway announced shortly before the meeting started that they will make a PR tomorrow.
<dangerousfreedom> There are really a lot of clean-ups and more comments to make but I think it would be better to have your feedback on it first. Even in a high level. You can play with the wallet (open many wallets and transfer enotes between them). -> https://github.com/DangerousFreedom1984/seraphis_lib/commit/9340e037e763cc69619d3a27883327e2bf060437
<dangerousfreedom> Just compile and run ./monero-wallet3
<rbrunner> Great, dangerousfreedom!
<rbrunner> A lot of things finally start to drop into place
<rbrunner> My little contribution was yet another rebase of our "seraphis_wallet" branch to koe's latest "seraphis_lib"
<rbrunner> I know and understand now the necessary trick, as explained patiently by jeffro256
<SNeedlewoods> dangerousfreedom I'll try to check your monero-wallet3 out soon
<rbrunner> jberman: I think everybody is also looking forward to your PR. Another big piece.
<rbrunner> Will this a lib PR, a wallet PR, or a two-part PR?
<rbrunner> *Will this be
<dangerousfreedom> Thanks! I will look at your PR soon also since my serialization is not working for legacy yet and it might be better to even go to a real ledger and then I would need to use your PR with jberman's scanner. I will think about it this week.
<jeffro256> Me: https://github.com/UkoeHB/monero/pull/31, https://github.com/UkoeHB/monero/pull/34, and https://github.com/UkoeHB/monero/pull/38 were merged into seraphis_lib. I'm working on a PR which will switch the way we index legacy enotes to match how we currently index enotes (amount, global index), so that we can have CLSAG rings in seraphis transactions w/o re-indexing the database
<rbrunner> Sounds a bit like magic ...
<rbrunner> Ah, no, just a switch back to the "old" system?
<jeffro256> yes
<jeffro256> So heads up @dangerousfreeedom, the internal structure of MockLedgerContext will change with this PR I'm working on, and thus the serialization code will have to update
<rbrunner> jberman, do you copy, this was a question meant for you: Will this a lib PR, a wallet PR, or a two-part PR?
<jberman> rbrunner I'm going to divide up the commits as cleanly as possible including small commits to the daemon RPC today, and then from there I think it'll be easier to see what should be PR'd where and at what time etc. Probably will be a number of small PR's
<rbrunner> Just making sure that we all are on the same boat regarding PRs
<dangerousfreedom> Yeah, everything is changing everytime haha. But hopefully we will start having an idea about the core of the wallet
<rbrunner> Thanks, jberman, sounds good
<jberman> jeffro256 have you seen this PR from SNeedlewoods that introduces an `enote_same_amount_index` ? https://github.com/UkoeHB/monero/pull/40
<jberman> *enote_same_amount_ledger_index
<rbrunner> Does this solve the same problem?
<rbrunner> Or is this an addition?
<jberman> It would enable indexing by amount + global index, same as today
<jeffro256> No IIUC, they should work together. That PR is for adding contextual information to legacy enote records, while the PR I'm working on changes the `LegacyRingSignatureV4` to include an enote amount for indexing the input members
<rbrunner> I guess jeffro256 will sort it out :)
<jberman> gotcha
<jberman> noice
<rbrunner> Alright. Do we have any separate subject to discuss today? Anybody want to bring up some general things?
<rbrunner> Nice that my incremental pool update code now becomes useful, "thanks" to the spam wave. Now we "only" have to get everybody to update
<dangerousfreedom> Haha thanks :p
<jberman> +1
<jeffro256> yeah that's great that incremental pool updating was implemented and tested before it was really really needed
<jeffro256> Usually not how the dev cycle goes here ;)
<rbrunner> Well, I did not have spam waves on my mind ...
<rbrunner> Ok, if nothing else I think we can close for today. Thanks everybody for the fantastic news regarding progress, and your attendance. Read you next week.
<jeffro256> Unrelated, and not to be selfish, but https://github.com/UkoeHB/monero/pull/26 still needs review, and it will affect most wallet-related things downstream. If anyone is brave enough to help review, Koe and I would greatly appreciate it
<jeffro256> But yes thank you everyone! Things are speeding up which is nice to see
<jberman> on my list :)
<rbrunner> Good luck, I hope you find a reviewer. That won't be me, however, that's definitely beyond my reach
from meta.
Related Issues (20)
- Seraphis wallet workgroup meeting #74 - Monday, 2024-06-17, 18:00 UTC HOT 1
- Cuprate Meeting #8 - Tuesday, 2024-06-18, 18:00 UTC HOT 1
- Monero Research Lab Meeting - Wed 19 June 2024, 17:00 UTC HOT 1
- Seraphis wallet workgroup meeting #75 - Monday, 2024-06-24, 18:00 UTC HOT 1
- Monero Community Workgroup Meeting: Saturday 22nd June 15:00UTC HOT 8
- Cuprate Meeting #9 - Tuesday, 2024-06-25, 18:00 UTC HOT 1
- Cuprate Meeting #10 - Tuesday, 2024-07-02, UTC 18:00 HOT 1
- Monero Research Lab Meeting - Wed 26 June 2024, 17:00 UTC HOT 1
- Seraphis wallet workgroup meeting #76 - Monday, 2024-07-01, 18:00 UTC HOT 1
- Monero Community Workgroup Meeting: Saturday 6th July 15:00UTC HOT 4
- Cuprate Meeting #11 - Tuesday, 2024-07-09, UTC 18:00 HOT 1
- Monero Research Lab Meeting - Wed 03 July 2024, 17:00 UTC HOT 1
- Seraphis wallet workgroup meeting #77 - Monday, 2024-07-08, 18:00 UTC HOT 1
- Cuprate Meeting #12 - Tuesday, 2024-07-16, UTC 18:00 HOT 1
- Monero Research Lab Meeting - Wed 10 July 2024, 17:00 UTC HOT 1
- Seraphis wallet workgroup meeting #78 - Monday, 2024-07-15, 18:00 UTC HOT 1
- Monero Community Workgroup Meeting: Saturday 20th July 15:00UTC HOT 1
- Cuprate Meeting #13 - Tuesday, 2024-07-23, UTC 18:00 HOT 1
- Monero Research Lab Meeting - Wed 17 July 2024, 17:00 UTC HOT 1
- Seraphis wallet workgroup meeting #79 - Monday, 2024-07-22, 18:00 UTC HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from meta.