Comments (3)
Yeah. That's definitely not right. I'm assuming this is somewhere in the git-ruby implementation since the behavior is different from git-rev-list
. I'm not super familiar with that code but I'll see what I can figure out.
from grit.
I wrote that pretty late at night and didn't trace it. I've gone back and confirmed that repo.commits(ref, options) does call rev_list, and I can fool Grit into calling out to native by passing :format => "UTF-8" to git.rev_list (not that I really want to go down that path).
it looks like Grit::GitRuby::Repository#walk_log determines the 'real' SHA correctly but the code that follows goes awry, since adding
return [commit_sha] if opts[:max_count] == 1 && opts.keys.size == 1
after commit_sha is determined gets me the correct value. It has to be said that that's not really a satisfactory fix for all kinds of reasons.
from grit.
Grit is no longer maintained. See #183 and check out libgit2/rugged.
from grit.
Related Issues (20)
- Hehe
- This is the first ever commit of GitHub. HOT 13
- help
- help
- issues HOT 1
- issues HOT 1
- https://github.com/ddurdle/repository.ddurdle.git
- https://github.com/ddurdle/repository.ddurdle.git
- https://github.com/ddurdle/repository.ddurdle.git
- A modified test idea for MyLibrary
- A modified test idea for MyLibrary
- Issue to Export
- Issue to Export
- Issue to Export
- Issue to Export
- Hello GitHub HOT 2
- b
- Title
- Hello from my CSharpGitHubApp Installation!
- Hello from my CSharpGitHubApp Installation!
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from grit.