Giter Club home page Giter Club logo

Comments (3)

rtomayko avatar rtomayko commented on July 28, 2024

Yeah. That's definitely not right. I'm assuming this is somewhere in the git-ruby implementation since the behavior is different from git-rev-list. I'm not super familiar with that code but I'll see what I can figure out.

from grit.

pellucidity avatar pellucidity commented on July 28, 2024

I wrote that pretty late at night and didn't trace it. I've gone back and confirmed that repo.commits(ref, options) does call rev_list, and I can fool Grit into calling out to native by passing :format => "UTF-8" to git.rev_list (not that I really want to go down that path).

it looks like Grit::GitRuby::Repository#walk_log determines the 'real' SHA correctly but the code that follows goes awry, since adding
return [commit_sha] if opts[:max_count] == 1 && opts.keys.size == 1
after commit_sha is determined gets me the correct value. It has to be said that that's not really a satisfactory fix for all kinds of reasons.

from grit.

bkeepers avatar bkeepers commented on July 28, 2024

Grit is no longer maintained. See #183 and check out libgit2/rugged.

from grit.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.