Giter Club home page Giter Club logo

Comments (14)

slawekjaranowski avatar slawekjaranowski commented on August 15, 2024 3

Ok, test added, build pass.
I will merge fix and release next version.

from flatten-maven-plugin.

zuisong avatar zuisong commented on August 15, 2024 2

Looks as is simple to fix, but reproduce project will be appreciated to have regression.

@slawekjaranowski
You can create a empty maven project, and pom.xml content. then run mvn compile

<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
         xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd">
  <modelVersion>4.0.0</modelVersion>
  <groupId>org.github.zuisong</groupId>
  <artifactId>flatten-maven-plugin-issue348</artifactId>
  <version>0.0.1</version>

  <dependencyManagement>
    <dependencies>
      <dependency>
        <groupId>com.github.vert-x3.vertx-stack</groupId>
        <artifactId>vertx-stack-depchain</artifactId>
        <version>4.4.0</version>
        <type>pom</type>
        <scope>import</scope>
      </dependency>
    </dependencies>
  </dependencyManagement>

  <repositories>
    <repository>
      <id>jitpack.io</id>
      <url>https://jitpack.io</url>
    </repository>
  </repositories>

  <build>
    <plugins>
      <plugin>
        <groupId>org.codehaus.mojo</groupId>
        <artifactId>flatten-maven-plugin</artifactId>
        <!-- it works on version 1.3.0  -->
        <version>1.4.0</version>
        <executions>
          <execution>
            <phase>process-resources</phase>
            <goals>
              <goal>flatten</goal>
            </goals>
          </execution>
          <execution>
            <id>flatten.clean</id>
            <phase>clean</phase>
            <goals>
              <goal>clean</goal>
            </goals>
          </execution>
        </executions>
      </plugin>
    </plugins>
  </build>
</project>

from flatten-maven-plugin.

zuisong avatar zuisong commented on August 15, 2024 2

It works now. ❤️

Could we use Spring Milestone Repository to add IT?

<project xmlns="http://maven.apache.org/POM/4.0.0"
  xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd">
  <modelVersion>4.0.0</modelVersion>
  <groupId>org.github.zuisong</groupId>
  <artifactId>flatten-maven-plugin-issue348</artifactId>
  <version>0.0.1</version>

  <dependencyManagement>
    <dependencies>
      <dependency>
        <groupId>org.springframework.boot</groupId>
        <artifactId>spring-boot-dependencies</artifactId>
        <version>3.0.0-M5</version>
        <type>pom</type>
        <scope>import</scope>
      </dependency>
    </dependencies>
  </dependencyManagement>

  <repositories>
    <repository>
      <id>repository.spring.milestone</id>
      <name>Spring Milestone Repository</name>
      <url>http://repo.spring.io/milestone</url>
    </repository>
  </repositories>
  <build>
    <plugins>
      <plugin>
        <groupId>org.codehaus.mojo</groupId>
        <artifactId>flatten-maven-plugin</artifactId>
        <!-- <version>1.4.1-SNAPSHOT</version> -->
        <version>1.4.0</version>
        <!-- <version>1.3.0</version> -->
        <executions>
          <execution>
            <phase>process-resources</phase>
            <goals>
              <goal>flatten</goal>
            </goals>
          </execution>
          <execution>
            <id>flatten.clean</id>
            <phase>clean</phase>
            <goals>
              <goal>clean</goal>
            </goals>
          </execution>
        </executions>
      </plugin>
    </plugins>
  </build>
</project>

from flatten-maven-plugin.

cstamas avatar cstamas commented on August 15, 2024 1

I believe this is the problem right here: https://github.com/mojohaus/flatten-maven-plugin/pull/336/files#diff-9f8ec1d13bc75e576b6c21b96d277373eb856d5465ef87ef675a983b3ade36beR1154

from flatten-maven-plugin.

slawekjaranowski avatar slawekjaranowski commented on August 15, 2024 1

@zuisong - thanks for example

I have created a fix - you can build locally plugin from branch fix-348 for your testing purpose

I don't know how artifacts in jitpack are managed - so I don't add example as IT.
I don't want to have failed test if something change in jitpack in the future.

from flatten-maven-plugin.

famod avatar famod commented on August 15, 2024 1

Thanks all!
It didn't occur to me that the BOM in question doesn't need to be internal, so thanks @zuisong for pointing that out by providing a very simple reproducer.

from flatten-maven-plugin.

pzygielo avatar pzygielo commented on August 15, 2024

I'm seeing similar.

from flatten-maven-plugin.

slawekjaranowski avatar slawekjaranowski commented on August 15, 2024

Can you provide a simple project which reproduce it?

from flatten-maven-plugin.

slawekjaranowski avatar slawekjaranowski commented on August 15, 2024

I'm seeing similar.

This change was really needed - yes it can introduce some of bugs which was not covered by IT.
So now we can improve it.

from flatten-maven-plugin.

famod avatar famod commented on August 15, 2024

Can you provide a simple project which reproduce it?

I suppose you need a repo manager (e.g. nexus) and an artifact that only exists in that repo.
Unfortunatly I don't have time for that currently, sorry.

from flatten-maven-plugin.

slawekjaranowski avatar slawekjaranowski commented on August 15, 2024

Looks as is simple to fix, but reproduce project will be appreciated to have regression.

from flatten-maven-plugin.

famod avatar famod commented on August 15, 2024

I won't be able to provide a reproducer anytime soon, sorry.
I'd gladly test a snapshot though (or build the plugin myself from a fix branch).

from flatten-maven-plugin.

zuisong avatar zuisong commented on August 15, 2024

Same problem to me

from flatten-maven-plugin.

zuisong avatar zuisong commented on August 15, 2024

flatten-maven-plugin-issue348.zip

from flatten-maven-plugin.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.