Comments (11)
I think you're right. I was thinking it was there for people who are more comfortable with mixins, but that's kind of a crutch, right?
from modularscale-sass.
Functions are better, they should learn them. Lets get rid of it.
from modularscale-sass.
If we do, don't forget that the classes mixin uses this https://github.com/scottkellum/modular-scale/blob/master/stylesheets/_modular-scale.sass#L208
from modularscale-sass.
I was about to delete it but then saw the classes mixin and the regular mixin next to each other. Might as well leave it in as they have a lot of similarities.
from modularscale-sass.
It's still a bit vestigial. I'm still thinking of taking it out, and rewriting the classes mixin accordingly. Should be a pretty simple change.
from modularscale-sass.
Yea, the classes mixin can get re-written accordingly to use the function instead.
from modularscale-sass.
I went ahead and deprecated it. For now running the mixin will send a warning to the console, but still work.
from modularscale-sass.
Which brings up a topic we should mention for extension devs, when to use @debug and @warn.
from modularscale-sass.
So many new things to learn.
from modularscale-sass.
good point. I'd love to draft something on that. I'd be lost w/o @debug
from modularscale-sass.
I have a start to a guide on if, for, each, while that has some uses of this in the code samples but nothing that dives into the subject. Take a peek at the read lists and feel free to add to them :)
from modularscale-sass.
Related Issues (20)
- Implement a way to disable viewport-based typography in version 3 ($ms-fluid: false) HOT 1
- Disable px rounding option HOT 3
- Output calculation as rem value HOT 2
- Both regular and non-conflict ms functions are returning raw output HOT 6
- Removal of ms-round-px causes build failure HOT 7
- SyntaxError on @import HOT 6
- Eyeglass v2.0.0 support HOT 3
- Deprecation warning HOT 1
- Not working for REM on media query HOT 5
- Can't make ms-respond to work HOT 6
- www.-less links to modularscale.com not redirecting
- No mixin named ms-respond HOT 2
- Eyeglass v3 support
- modularscale.com & www.modularscale.com are redirecting to separate websites HOT 3
- Deprecation warnings after upgrading Sass when using `ms` Variable HOT 21
- Changes to responsive logic HOT 2
- On CSS locks and `clamp()` HOT 6
- 4.x - Importing modular scale using ratio string results in an error
- A lite dart-sass implementation, and proposal for contribution HOT 3
- Syntax for responsive HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from modularscale-sass.