Giter Club home page Giter Club logo

Comments (11)

codingdesigner avatar codingdesigner commented on May 12, 2024

I think you're right. I was thinking it was there for people who are more comfortable with mixins, but that's kind of a crutch, right?

from modularscale-sass.

scottkellum avatar scottkellum commented on May 12, 2024

Functions are better, they should learn them. Lets get rid of it.

from modularscale-sass.

adamstac avatar adamstac commented on May 12, 2024

If we do, don't forget that the classes mixin uses this https://github.com/scottkellum/modular-scale/blob/master/stylesheets/_modular-scale.sass#L208

from modularscale-sass.

scottkellum avatar scottkellum commented on May 12, 2024

I was about to delete it but then saw the classes mixin and the regular mixin next to each other. Might as well leave it in as they have a lot of similarities.

from modularscale-sass.

codingdesigner avatar codingdesigner commented on May 12, 2024

It's still a bit vestigial. I'm still thinking of taking it out, and rewriting the classes mixin accordingly. Should be a pretty simple change.

from modularscale-sass.

adamstac avatar adamstac commented on May 12, 2024

Yea, the classes mixin can get re-written accordingly to use the function instead.

from modularscale-sass.

codingdesigner avatar codingdesigner commented on May 12, 2024

I went ahead and deprecated it. For now running the mixin will send a warning to the console, but still work.

from modularscale-sass.

adamstac avatar adamstac commented on May 12, 2024

Which brings up a topic we should mention for extension devs, when to use @debug and @warn.

from modularscale-sass.

scottkellum avatar scottkellum commented on May 12, 2024

So many new things to learn.

from modularscale-sass.

codingdesigner avatar codingdesigner commented on May 12, 2024

good point. I'd love to draft something on that. I'd be lost w/o @debug

from modularscale-sass.

adamstac avatar adamstac commented on May 12, 2024

I have a start to a guide on if, for, each, while that has some uses of this in the code samples but nothing that dives into the subject. Take a peek at the read lists and feel free to add to them :)

from modularscale-sass.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.