[BUG] Values get set to 1 when passing one Scalar into another Scalar's constructor about mojo HOT 5 CLOSED

Related to #2860. Duplicate of #3045.

from mojo.

FYI @laszlokindrat @ConnorGray @bethebunny

from mojo.

This is not just confusing but actively harmful.

Much code in math uses the following pattern:

fn f(a: SIMD, ...) -> SIMD[res_type, ...]:
  ...
  fn _float32_dispatch(): ...
  fn _float64_dispatch(): ...

  if type is DType.float32:
    return _simd_apply[_float32_dispatch](a, ...).cast[res_type]()
  ...

With the implicit conversion to Bool, the compiler no longer able to warn us if the final cast is missing, which is dangerous and not at all obvious to see (it's no longer a matter of avoiding direct constructors call like Int64(n)).

from mojo.

@joe Do you want to keep this around for for the math module issue or dup out to #3045?

from mojo.

Closing as duplicate of #3045 is fine by me.

from mojo.