Giter Club home page Giter Club logo

Comments (5)

jayzhan211 avatar jayzhan211 commented on May 24, 2024 3

+1 for this.

I would even prefer if the main branch is the current nightly branch for daily development. And, the stable branch is the current main branch for cutting release.

The reason that the main branch is is the default right now is to support the users that download the released versions of Mojo and want to run the examples.

Is it possible to redirect link to the release branch? If they jump into the repo instead of the official site, we can direct them with README.md

from mojo.

gabrieldemarmiesse avatar gabrieldemarmiesse commented on May 24, 2024 1

While this is in no way the exact list of all the PRs that have wrongfully targeted main, here is the list of PRs that target main and were not accepted after the stdlib became open source: https://github.com/modularml/mojo/pulls?q=is%3Apr+base%3Amain++is%3Aunmerged+created%3A%3E2024-03-28 . That can be used as a data point to understand the problem I'm talking about.

If we assume that https://github.com/modularml/mojo/pulls?q=is%3Apr+base%3Anightly+is%3Aclosed+created%3A%3E2024-03-28+-author%3AJoeLoser+ is the list of PR merged in nightly by the community, the number of PRs that targeted the wrong branch by the community is around ~10% of all opened PRs, which is significant.

If I may add, new contributors aren't necessarily the ones that will +1 this, because it's a mistake that contributors make once and will never make again. So it might not seem important when the contributor has learned that nightly is the right target.

Maybe there is something we can work out about the examples to still keep this workflow while still changing the main branch? If someone from the community has an idea there it would be great :)

from mojo.

gabrieldemarmiesse avatar gabrieldemarmiesse commented on May 24, 2024 1

Would it help if there was a cross-platform bash script or something similar with the right git instructions that did the right thing to set up fix branch locally?

I don't think the issue is here. The problem is in the github UI as mentionned in the issue description and a bash script won't change the UI.

from mojo.

ematejska avatar ematejska commented on May 24, 2024

Thanks for filing this. Would love the community to +1 if this is important to other folks. The reason that the main branch is is the default right now is to support the users that download the released versions of Mojo and want to run the examples.

from mojo.

ksandvik avatar ksandvik commented on May 24, 2024

Would it help if there was a cross-platform bash script or something similar with the right git instructions that did the right thing to set up fix branch locally?

from mojo.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.