v1.x and PHP 8 compatibility issue (Symfony Yaml) about gitify HOT 7 CLOSED

I'd definitely encourage using v2 if you can as that has all the dependencies brought freshly up to date. I'm a little worried about introducing issues into v1 by changing dependencies there, although it does look like the update in v2 was pretty smooth.

For the differences with v2 see: https://github.com/modmore/Gitify#upgrading-to-v2-warn-in-development

from gitify.

Thanks Mark! That's definitely an option i did not consider (because of "alpha"), but sounds sensible.
Completely getting your concern about breaking things on v1.x branch... that was mostly to share our experience.

Many thanks ;)

from gitify.

Before closing this... @muzzwood: Given you handled the dependency updates, do you have any thoughts?

from gitify.

The dependency upgrade was indeed smooth. Depending on the minimum requirements for the dependencies, perhaps we could upgrade them for v1 to the lowest version that works with PHP8 (YAML 3.3.18 as indicated by @rtripault) without any pitfalls. 🤔

from gitify.

Let's do that then to keep 1.x supported at least a little longer then - at least until V2 is launched as stable and gitify watch is updated.

from gitify.

Sounds good! I'll aim to get that done tomorrow.

from gitify.

Closing as symfony/yaml has now been upgraded to 3.3.* in Gitify v1
57ecdb6

Thanks for reporting this @rtripault !

from gitify.