Giter Club home page Giter Club logo

Comments (24)

Dubzer avatar Dubzer commented on May 27, 2024 2

It would be great if it was calculated according to screen height. But as it will require an additional work, I think 2, or maybe 3 is enough

from modernflyouts.

ShankarBUS avatar ShankarBUS commented on May 27, 2024 2

Hey @Dubzer, the ability to auto hide the "More Controls" button has been added in 8754e25

The 1st half of this request is postponed to v0.8 😅. But please be patient until your request is implemented.

from modernflyouts.

Samuel12321 avatar Samuel12321 commented on May 27, 2024 2

I agree with @Cyberdroid1, the current terminology can be confusing. i personally think the option to select the maximum number of vertical media controls should be disabled or hidden when set to horizontal. Otherwise it seems like this feature also occurs horizontally.

from modernflyouts.

Samuel12321 avatar Samuel12321 commented on May 27, 2024 2

Found out how to make them work.
Regarding translation PR's i will review them and merge them when it suits.

from modernflyouts.

Dubzer avatar Dubzer commented on May 27, 2024 1

We may have had a misunderstanding, so I made this concept:

concept

So I'm not suggesting returning the old style.

Scrolling vertically would take up a lot of the available screen space and my be irritating to users with small displays.

I don't mean scrolling, but statically positioned. And because of small displays I suggest to make it optional. Something like "Always show all media sources", and it would switch between current behavior and suggested.

Anyway, thank you for your job!

from modernflyouts.

ShankarBUS avatar ShankarBUS commented on May 27, 2024 1

@Dubzer,

Sorry for taking too long (~3 months) to implement this 😅.
And thank you so much for proposing this idea ✌.

Your proposal has been implemented in 7e587f1

image

Currently the settings window is messed up, so all options are placed on a single page. I'm working on reorganizing it.
There won't be a 2px gap between those media controls like it used to in v0.2.0

The highest number of media controls that can be shown vertically is currently 10. Should I increase this?

I hope I did what you wanted.

If you're still willing to use this app, wait till v0.8 is released. Feel free to propose new ideas 👍 😁

from modernflyouts.

Samuel12321 avatar Samuel12321 commented on May 27, 2024 1

definitely think the gap is needed.

from modernflyouts.

Samuel12321 avatar Samuel12321 commented on May 27, 2024 1

Would you guys shut up now?

Sorry?

from modernflyouts.

Samuel12321 avatar Samuel12321 commented on May 27, 2024 1

Sorry, i misinterpreted your statement.

Yes, it will be a good feature to have.

from modernflyouts.

prakharb5 avatar prakharb5 commented on May 27, 2024 1

Can we also reduce it to 1? And what's the behaviour, say I set it to 2, but I have 3 media sources. What will be the behaviour for that?

from modernflyouts.

ShankarBUS avatar ShankarBUS commented on May 27, 2024 1

It will show scroll buttons if the controls are more than the max count.

Why are you even confused about this 🤣? The terminology apparently 😅.

Any suggestion for the sentence to show there?

I added the ability to switch between vertical and horizontal stacking. Only the vertical layout will have spacing and the ability to show multiple session controls.

from modernflyouts.

ShankarBUS avatar ShankarBUS commented on May 27, 2024

Well I wanted it to be similar to Windows 10X's UI. So instead of creating a separate UI, I recreated the Windows 10X Media control UI.

Windows 10X media UI

And I won't change my decision about this. (Would be consistent with win 10 once it's UI is updated)

Scrolling vertically would take up a lot of the available screen space and my be irritating to users with small displays.

And for the "three dots button" it could be hidden (later) if no options are available.

I'm not adamant of this decision but some decisions like this have to be made and the users must be let go choose what they what. If enough people vote for the old UI, you may expect a comeback of it. I'm currently tight on schedule. So that's it

from modernflyouts.

ShankarBUS avatar ShankarBUS commented on May 27, 2024

Hey @Dubzer, so you want to keep the new UI but need an option to show multiple session controls vertically and not one at a time in horizontal.

That could be done, it would be a nice little feature. It's also easy to be done.

Edit :

How many card do you want to show before scroll buttons appear? The old UI had a max-height of 198 and will show scroll buttons when expanded above that.

from modernflyouts.

ShankarBUS avatar ShankarBUS commented on May 27, 2024

Hey @Sameul12321, since this feature will require changes in settings (i.e. reorg). Can you move this issue from v0.7 project to v0.8?

from modernflyouts.

Samuel12321 avatar Samuel12321 commented on May 27, 2024

Hey @Sameul12321, since this feature will require changes in settings (i.e. reorg). Can you move this issue from v0.7 project to v0.8?

sure

from modernflyouts.

ShankarBUS avatar ShankarBUS commented on May 27, 2024

Would you guys shut up now?

image

Could you see the 8px spacing?

from modernflyouts.

ShankarBUS avatar ShankarBUS commented on May 27, 2024

I was joking 😂. Do you guys like it?

from modernflyouts.

prakharb5 avatar prakharb5 commented on May 27, 2024

Any suggestion for the sentence to show there?

I didn't get you. What sentence?

from modernflyouts.

ShankarBUS avatar ShankarBUS commented on May 27, 2024

What should be the header for the new vertical media controls count option?

Currently it is Maximum Number of Media Session Controls vertically. It seems to be confusing. We need a replacement for that.

Any suggestions?

from modernflyouts.

prakharb5 avatar prakharb5 commented on May 27, 2024

I think Maximum media session controls

I say we hide this setting or grey it out when horizontal mode is selected.

from modernflyouts.

ShankarBUS avatar ShankarBUS commented on May 27, 2024

No we shouldn't (we can but we shouldn't). They are independent of each other and should be independently controllable.

I added vertically to reduce confusion.

What about Maximum Number of Media Session Controls to show vertically then?

If you still insist on disabling it while choosing Horizontal, we can do that.

from modernflyouts.

prakharb5 avatar prakharb5 commented on May 27, 2024

I am getting a bit confused. Lets clear one point. Is this feature for multiple flyouts available in horizontal mode?

from modernflyouts.

ShankarBUS avatar ShankarBUS commented on May 27, 2024

Is this feature for multiple flyouts available in horizontal mode?

No, that's I've been saying all along

from modernflyouts.

ShankarBUS avatar ShankarBUS commented on May 27, 2024

Ok that's cool, we already need to update some sentences to make them clean and professional.

We can do this together with that.

Hey @Samuel12321, we are getting translation PRs at unwanted times, what should we do?

Let's say i introduce a temporary string like the previously mentioned one, people are updating the translations even for the temporary strings.

It is hard to maintain consistency across the resx files. The commit history will be unnecessarily filled. I am still confused about the past PRs, would they even work? Why merge them if they don't work?

How should they help us with multilingual support?

How and when should we accept translation PRs?

What about the xlf files & Multilingual App Toolkit?

from modernflyouts.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.