Giter Club home page Giter Club logo

Comments (16)

ShankarBUS avatar ShankarBUS commented on May 27, 2024 2

@Cyberdroid1, I have also added timeline info support to it in digimezzo/dopamine-windows#1206

Let's hope this will also get merged

from modernflyouts.

prakharb5 avatar prakharb5 commented on May 27, 2024 1

Thanks. I really think I am cursed sometimes because of the kinds of bugs I face. XD

from modernflyouts.

prakharb5 avatar prakharb5 commented on May 27, 2024 1

Can you try reproducing this issue on your side? I expect the same behaviour as mine.

from modernflyouts.

ShankarBUS avatar ShankarBUS commented on May 27, 2024 1

Hey @Cyberdroid1

Is this what you are saying?

image

image

Currently they doesn't support shuffle/repeat/stop externally, so we can't hook those controls.

I contacted @digimezzo, they are open for contributions. I will open a PR for this.

from modernflyouts.

prakharb5 avatar prakharb5 commented on May 27, 2024 1

Yes, I meant this only.

Thanks so much!

from modernflyouts.

ShankarBUS avatar ShankarBUS commented on May 27, 2024 1

@Cyberdroid1,

Done! Opened a PR on the target. I will close this issue, you can track the PR on that repo. If it gets merged, it will be good for us.

The PR : digimezzo/dopamine-windows#1201

My part's done.

from modernflyouts.

prakharb5 avatar prakharb5 commented on May 27, 2024 1

Yay! Thanks so much, bro! Nice to see this get accepted!

from modernflyouts.

ShankarBUS avatar ShankarBUS commented on May 27, 2024

Is that supported by the stock windows flyout?

from modernflyouts.

prakharb5 avatar prakharb5 commented on May 27, 2024

Stock flyout just shows play/pause, previous, next. Same supported by ModernFlyouts. Don't know whether it supports skip, repeat, stop, etc.

from modernflyouts.

ShankarBUS avatar ShankarBUS commented on May 27, 2024

It's up-to the app whether to support repeat, stop, shuffle & etc. We're just using a public API that has some limitations. I would recommend you to open a issue on the dopamine-windows repo and ask them to support these controls. We can't do anything about this.

If the repo is active and I have free time, I can open a pull request with the said feature.

from modernflyouts.

prakharb5 avatar prakharb5 commented on May 27, 2024

The repo is active. I will open the issue.

from modernflyouts.

prakharb5 avatar prakharb5 commented on May 27, 2024

A weird bug now. Whenever I launch this app and use shortcuts to skip, play/pause, etc. in this music player, the system UI pops up with the media flyout. ModernFlyout is not even showing the media flyout! It doesnt know whether music is playing or not.

Would request to reopen this issue.

from modernflyouts.

ShankarBUS avatar ShankarBUS commented on May 27, 2024

Yep reopen it. Seems to be a different issue. But it may take weeks to fix this one.

from modernflyouts.

prakharb5 avatar prakharb5 commented on May 27, 2024

I don't have the button to reopen it, weirdly.

image

from modernflyouts.

ShankarBUS avatar ShankarBUS commented on May 27, 2024

Done!

from modernflyouts.

ShankarBUS avatar ShankarBUS commented on May 27, 2024

Hey @Cyberdroid1, the PR has been accepted & got merged by the Dopamine-windows team 🎊🎊🎊🎉🎉🎉

from modernflyouts.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.