Giter Club home page Giter Club logo

Comments (6)

ShankarBUS avatar ShankarBUS commented on May 24, 2024 2

Ohhhh! That's a nice catch 👏👏👏. We can actually do that but I forgot the scenario 🤦‍♂️. It should definitely be the way you suggested. Thanks again pal.

from modernflyouts.

ShankarBUS avatar ShankarBUS commented on May 24, 2024 2

@Samuel12321, Thank you for your suggestions!

Your request has been implemented in fdf6f13

from modernflyouts.

Samuel12321 avatar Samuel12321 commented on May 24, 2024 1

i personally think it should show the no connected audio devices message when volume keys pressed as well.

from modernflyouts.

Samuel12321 avatar Samuel12321 commented on May 24, 2024

just tested, no flyout appears?

from modernflyouts.

ShankarBUS avatar ShankarBUS commented on May 24, 2024

No flyout should appear! that's the correct behaviour (while pressing the volume keys). But if you press the media keys (previous, next, play/pause), you will see a message saying "No Connected Audio Devices" instead of showing the useless volume control

from modernflyouts.

ShankarBUS avatar ShankarBUS commented on May 24, 2024

Yes it should be! But there is no way to detect the volume trigger (when no audio devices are connected) with the current SHELL_HOOK method, we'd need to fallback to the old method (i.e. LL Key Hook) to detect the volume keys even when no audio devices are connected.

I forgot to check how the Windows stock flyout works.

Edit : Checked the stock one, it doesn't show the flyout even after pressing all the media keys. So what we currently have must be good

from modernflyouts.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.