OrderBook level issue about coinbase-pro-sdk HOT 7 CLOSED

Nice!! thank you for this awesome wrapper, are changes already available on Composer?

from coinbase-pro-sdk.

@Sm4rtK1dz yes it is 😃 last release v0.9.4

from coinbase-pro-sdk.

I've found the bug that was making this happen, the problem seems to be that the $level variable was orphan and not used within the function.

I've fixed it and made a pull request to your repository.

from coinbase-pro-sdk.

Thanks for reporting, I will close after merge of #24

from coinbase-pro-sdk.

Done 🎉 #24 Commit b2f3a05

Thanks to @Sm4rtK1dz

from coinbase-pro-sdk.

Hey @Sm4rtK1dz and @MockingMagician, I am also having an issue with private properties. I'm simply trying to get historical data using getHistoricRates but all the properties (startTime, lowestPrice, highestPrice, etc.) are private. How can I use/save these values from the object? Kinda odd that they'd be private properties as is since it's simply historical data?

EDIT: After playing around with it a bit more, I see that I can get back a usable object by calling getCandles method on the results.

EDIT 2: Well I spoke too soon. Even though getCandles returns a seemingly normal object, each of the properties in it are also private and thus not accessible.

EDIT 3: My apologies for endless chain of edits, but I think I've figured it out. Essentially need to access each individual property using the getter methods such as $historic->getCandles()[0]->getLowestPrice()

from coinbase-pro-sdk.

@zenichanin yes it is the way you will have to do it.

$historic->getCandles() is an iterable so you can access all candles if you iterate over it.

By the way, do not hesitate to launch a new issue if you have any question. Talking into a closed one might not be seen.

from coinbase-pro-sdk.