propTypes definitions cause unneeded component updates about mobx-react HOT 6 CLOSED

Made a change where using the propTypes provided by mobx-react will use untracked. This doesn't solve it for the general case though. Either using typescript 😉, or production will avoid this issue. So since this is only a dev problem, a further won't fix for now.

from mobx-react.

I don't think you are doing anything wrong: React does prop type checking in the parent component (in order to output meaningful error messages such as "Check render() method of component X").

These prop type checks result in these observables being reported observed, i.e. they are added as extra dependencies of the parent component (in addition to the child component).

I stumbled upon this issue myself a couple of days ago. Unfortunately, I don't have a solution for this.

It makes using the mobx-react devtools harder because parent components show as changed as well. It also hurts performance somewhat, since two re-renders have to happen: one for the actual component and one for the parent which only accidentally is added as observer (only due to prop type checking).

from mobx-react.

Will this be an issue running the prod build of React? I thought React only checks against the propTypes in dev mode?

from mobx-react.

See also mobxjs/mobx#305

from mobx-react.

I think this can be circumvented by having mobx-react provide it's own propTypes, that leverage mobx.untracked, will investigate

from mobx-react.

Stumbled upon this issue today when used PropTypes.arrayOf() :(

from mobx-react.