Comments (9)
What version are you running? ietf-comments -v
.
from ietf-comments.
$ ietf-comments -v
0.0.4
Install log was:
$ pip install ietf-comments
Collecting ietf-comments
Downloading ietf_comments-0.0.4-py3-none-any.whl (7.0 kB)
Collecting commonmark
Downloading commonmark-0.9.1-py2.py3-none-any.whl (51 kB)
[...]
Installing collected packages: commonmark, ietf-comments
[...]
Successfully installed commonmark-0.9.1 ietf-comments-0.0.4
...
from ietf-comments.
Yeah, I didn't read the part about Python 3.10.
from ietf-comments.
:)
I just pushed 0.2.2, which drops the Python requirement to 3.6 but errors if you use a feature that requires 3.10 (currently, just rfced-comments
.
Unfortunately, pip will install the latest version of a package that supports the version of Python that you're using -- even if it's very old, and silently. I've opened a bug over there, but they don't seem likely to address it anytime soon.
from ietf-comments.
Thank you for the update. Now I get:
$ ietf-comments -g core-wg/core-problem-details AD\ Review\ of\ draft-ietf-core-problem-details-04.eml -a
Traceback (most recent call last):
File "/Users/cabo/bin/ietf-comments", line 5, in <module>
from ietf_comments.ui import ietf_comments_cli
File "/Users/cabo/lib/python3.9/site-packages/ietf_comments/ui.py", line 6, in <module>
from .xml_comments import parse_xml_comments
File "/Users/cabo/lib/python3.9/site-packages/ietf_comments/xml_comments.py", line 21, in <module>
class XmlCommentHandler(xml.sax.handler.LexicalHandler):
AttributeError: module 'xml.sax.handler' has no attribute 'LexicalHandler'
from ietf-comments.
Ah. Try 0.2.3.
Thanks.
from ietf-comments.
I'm not lucky today.
$ ietf-comments -g core-wg/core-problem-details AD\ Review\ of\ draft-ietf-core-problem-details-04.eml
Traceback (most recent call last):
File "/Users/cabo/bin/ietf-comments", line 8, in <module>
sys.exit(ietf_comments_cli())
File "/Users/cabo/lib/python3.9/site-packages/ietf_comments/ui.py", line 82, in ietf_comments_cli
comments = parse_markdown_comments(args.comment_file, cli)
File "/Users/cabo/lib/python3.9/site-packages/ietf_comments/md_comments.py", line 162, in parse_markdown_comments
renderer.render(doc)
File "/Users/cabo/lib/python3.9/site-packages/commonmark/render/renderer.py", line 19, in render
getattr(self, type_)(event['node'], event['entering'])
File "/Users/cabo/lib/python3.9/site-packages/ietf_comments/md_comments.py", line 81, in block_quote
change_location = self.changes.find_change_line(content)
File "/Users/cabo/lib/python3.9/site-packages/ietf_comments/changes.py", line 33, in find_change_line
if old_words[0] in line_words or words_consumed > 0:
IndexError: list index out of range
$ ietf-comments -v
0.2.3
Input copy-pasted from https://mailarchive.ietf.org/arch/msg/core/UnvM0Am3w4w2sU85i1PaTRBMvdc
from ietf-comments.
Try 0.2.4.
Is there one or more lines with just >
on them, surrounded by blank lines, by any chance?
from ietf-comments.
Input was: https://mailarchive.ietf.org/arch/msg/core/UnvM0Am3w4w2sU85i1PaTRBMvdc
There are > lines, but with a "Section nnn" right before them (no blank lines).
0.2.4: looks much better now:
$ ietf-comments -g core-wg/core-problem-details AD\ Review\ of\ draft-ietf-core-problem-details-04.txt -a
Warning: Unrecognised h2 section notes.
Document: draft-ietf-core-problem-details
Revision: 04
CC: @fpalombini
(Now I need to find out why authentication fails.)
from ietf-comments.
Related Issues (14)
- Creating a response to the review HOT 1
- README talks about GITHUB_ACCESS_TOKEN, but needs GITHUB_AUTH_TOKEN HOT 1
- Online server to validate comments? HOT 3
- Pip install confused me HOT 2
- ietf-comments fails to generate issues on github HOT 1
- Restart recommendations are inaccurate, resulting in duplicate issues
- Charters
- Please document permissions required
- Loop reviewer into issues
- Extract resolutions from GH issues for reply e-mails HOT 1
- invalid repo name prints "Error: Not Found" HOT 1
- Lars' Mega-Issue HOT 10
- Comments after h2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ietf-comments.