Giter Club home page Giter Club logo

Comments (6)

mm2 avatar mm2 commented on September 26, 2024 1

Hello Diogo, thanks for contacting.
Of course it will help a lot if you can setup a PR so after code scrutiny we could integrate it. Thanks for your help!

from little-cms.

diogoteles08 avatar diogoteles08 commented on September 26, 2024

Sure! I'll raise a PR shortly =)

from little-cms.

mm2 avatar mm2 commented on September 26, 2024

Thanks for the PR, will merge it soon

from little-cms.

diogoteles08 avatar diogoteles08 commented on September 26, 2024

Hey @mm2,
I'm coming back to this issue because seems like the changes of my PR #368 are not on the code anymore. However I looked into the commit history and there is no commit directly removing the changes. Was the removal intentional? If not, I'd be happy to raise a new PR fixing it

from little-cms.

mm2 avatar mm2 commented on September 26, 2024

@diogoteles08
Many thanks for pointing out, I didn't notice those changes were lost. No, it was not intentional, I assume the PR I accepted for meson build broke the file. It would be great if you could manage to setup a PR. Thanks again!

from little-cms.

diogoteles08 avatar diogoteles08 commented on September 26, 2024

Great! I've just opened a new PR on this.

My core job is to look over important OSS projects and suggest security enhancements, so I'll be around to suggest and possibly implement changes like this one. However, if you'd like to take a closer look yourself into the security posture of your repo, you can use the Scorecard GitHub Action. It would automatically run some security checks over your repo and propose fixes directly on your Security Tab. As an example, it would have alerted you when my changes on the permissions were lost.

Additionally, if you decide to make the security changes yourself, your changes might be eligible to financial rewards through Secure Open Source Rewards 😄.

from little-cms.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.