collectionHelpers looks quite ill-designed about paradox HOT 6 CLOSED

Yes the name is strange and it's not final. It's a proof of concept in a way

look at this example

th.paramset.flat.collection = ParamSetFlat$new(
  id = 'th.param.flat.collection',
  params = c(
    list(
      ParamInt$new(id = 'th.param.nat', default = 1L, lower = 1L, upper = 10L)
    ),
    createCollectionParamList(10L, ParamReal$new(id = 'th.param.real.na', default = 0, lower = -10, upper = 10, special.vals = NA))
  ),
  trafo = collectionHelper(fun = function(x, dict, tags) {
    xm = as.matrix(as.data.table(x))
    col.ind = seq_len(ncol(xm))
    ind.mat = sapply(dict$th.param.nat, function(z) col.ind <= z)
    ind.mat = t(ind.mat)
    xm[!ind.mat] = NA
    xm = xm / rowSums(xm, na.rm = TRUE)
    list(vector.param = lapply(seq_len(nrow(xm)), function(z) xm[z,]))
  }, collection.param.id = "th.param.real.na", additional.params = "th.param.nat")
)

x = th.paramset.flat.collection$sample(3)
th.paramset.flat.collection$transform(x)

from paradox.

it would be much easier
a) to make the baisc functionality of the rest of package work when so much other stuff is still very broken
b) for stuff like this to clearly write down first what you want to achieve.
the docs of collectionHelper dont say a single word about what the intended usage is.

maybe at least write down here what the idea is?

from paradox.

as i have to now guess again what things are supposed to mean:

the problem with scalar param replication is that you later need to figure what belongs together.
in terms of parameters in a set, and in terms of values in a list.
so one should give the user exactly this operation.

from paradox.

Can you read the README and tell me what you would improve?

from paradox.

this doesnt exist anymore? @jakob-r close?

from paradox.

Does not exist anymore.

from paradox.