Giter Club home page Giter Club logo

Comments (1)

aniketsharma00411 avatar aniketsharma00411 commented on June 18, 2024

The naming scheme and use of Matrix methods should be similar to that of Python NumPy. Accordingly, read_csv method should be changed to genfromtxt.

Steps to follow:

1. Update the read_csv method in matrix_read.hpp to take delimiter as an argument.

2. Rename read_csv to genfromtxt and add it in matrix_operations.hpp

3. Delete matrix_read.hpp and update Matrix.hpp to remove the statement which includes matrix_read.hpp

4. Update the README.md accordingly

5. Rename examples/read_csv.cpp to examples/genfromtxt.cpp and update the example accordingly.

6. In examples/CMakeLists.txt, update the line add_executable(read_csv read_csv.cpp) to add_executable(genfromtxt genfromtxt.cpp)

7. Rename benchmark/BM_read_csv.cpp to benchmark/BM_genfromtxt.cpp and update the benchmark to use new method name.

8. Delete benchmark/linux_binaries/BM_read_csv and generate new binary using `g++ benchmark/BM_genfromtxt.cpp -std=c++11 -I./include/ -isystem ./lib/benchmark/include -L./lib/benchmark/build/src -lbenchmark -lpthread -o ./benchmark/linux_binaries/BM_genfromtxt`

9. Rename BM_read_csv in benchmark/BM_all.cpp to BM_genfromtxt update the method call according to the new name. Also, position the method according to lexicographical order.

10. Recompile benchmark/BM_all.cpp using `g++ benchmark/BM_all.cpp -std=c++11 -I./include/ -isystem ./lib/benchmark/include -L./lib/benchmark/build/src -lbenchmark -lpthread -o ./benchmark/linux_binaries/BM_all`

Note: All the above steps should be a part of one commit with the message "Renames read_csv to genfromtxt".

@Makaveli I have added step 6.

from matrix.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.