Comments (1)
The naming scheme and use of Matrix methods should be similar to that of Python NumPy. Accordingly, read_csv method should be changed to genfromtxt.
Steps to follow:
1. Update the read_csv method in matrix_read.hpp to take delimiter as an argument. 2. Rename read_csv to genfromtxt and add it in matrix_operations.hpp 3. Delete matrix_read.hpp and update Matrix.hpp to remove the statement which includes matrix_read.hpp 4. Update the README.md accordingly 5. Rename examples/read_csv.cpp to examples/genfromtxt.cpp and update the example accordingly. 6. In examples/CMakeLists.txt, update the line add_executable(read_csv read_csv.cpp) to add_executable(genfromtxt genfromtxt.cpp) 7. Rename benchmark/BM_read_csv.cpp to benchmark/BM_genfromtxt.cpp and update the benchmark to use new method name. 8. Delete benchmark/linux_binaries/BM_read_csv and generate new binary using `g++ benchmark/BM_genfromtxt.cpp -std=c++11 -I./include/ -isystem ./lib/benchmark/include -L./lib/benchmark/build/src -lbenchmark -lpthread -o ./benchmark/linux_binaries/BM_genfromtxt` 9. Rename BM_read_csv in benchmark/BM_all.cpp to BM_genfromtxt update the method call according to the new name. Also, position the method according to lexicographical order. 10. Recompile benchmark/BM_all.cpp using `g++ benchmark/BM_all.cpp -std=c++11 -I./include/ -isystem ./lib/benchmark/include -L./lib/benchmark/build/src -lbenchmark -lpthread -o ./benchmark/linux_binaries/BM_all`
Note: All the above steps should be a part of one commit with the message "Renames read_csv to genfromtxt".
@Makaveli I have added step 6.
from matrix.
Related Issues (20)
- CMake version
- CMake not working for windows HOT 1
- Rename concat to concatenate
- Rename del to delete HOT 6
- Create a Contributing guide
- Create issue template
- Create Pull Request template
- Doxygen from comments HOT 1
- Google Test
- [FR] cmake for Unit Tests HOT 2
- [FR] Since the Readme is too long, a Table of Contents is needed.
- [FR] Function overloading for init() method
- [FR] CMake should install google benchmark and googletest
- [BUG] Add `const` keyword to methods wherever appropriate HOT 5
- Add more unit tests to cover more edge cases
- Separate current .hpp into .hpp and .cpp HOT 2
- [FR] Add GitHub Socialify in README HOT 4
- Replace dataset used in examples HOT 1
- [BUG] Compiling benchmarks and tests in Windows results in an error
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from matrix.