Giter Club home page Giter Club logo

Comments (7)

psyhtest avatar psyhtest commented on August 16, 2024

The rules actually mention <system_desc_id>_<implementation_id>_<scenario>.json in the title, as <system_desc_id>_<implementation_id>.json in the text of that section. It seems that _<scenario> is superfluous here?

Furthermore, no examples are provided ([ TODO David Kanter to add ]). But surely "Starting weights filename?" is benchmark-specific? Should <implementation_id be actually benchmark_id? Or are we missing a whole level here?

from policies.

guschmue avatar guschmue commented on August 16, 2024

fixed with this PR: mlcommons/inference#496

We now allow what the doc wants <system_desc_id>_<implementation_id>_<scenario>.json but we also allow <system_desc_id>_<implementation_id>.json

from policies.

psyhtest avatar psyhtest commented on August 16, 2024

Thanks @guschmue. I'm still not clear what implementation_id is. For the code/ subdir, I had to set it to task+'_'+scenario, where task is image-classification or object-detection, to make the checker happy, but I'm not sure if it's right.

from policies.

guschmue avatar guschmue commented on August 16, 2024

this says
code/benchmark/implementation_id
and in my case I used reference as implementation_id. It is undefined what the structure below that. I did not want to have the full inference tree there so I created a README that says git clone https://github.com/mlperf/inference

from policies.

psyhtest avatar psyhtest commented on August 16, 2024

Thanks @guschmue, I think I get it now.

Do you have structure like this then:

code/
  mobilenet/
    reference/
      README.md
  resnet/
    reference/
      README.md
  ...

where each README.md is identical? It's even worse in my case where for one implementation (image-classification-tflite) I have dozens of models (mobilenet*) and hence duplicate leaf README.mds.

It seems it would be better to swap the levels:

code/
  reference/
    mobilenet/
      README.md
    resnet/
      README.md

from policies.

psyhtest avatar psyhtest commented on August 16, 2024

(although this doesn't solve the problem of duplicate README.mds...)

from policies.

guschmue avatar guschmue commented on August 16, 2024

Yes, I agree. That also would enable us to use code/implementation_id for everything as default that does not explicitly list a model. v0.7 I guess @petermattson .

from policies.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.